Skip to content

Conversation

kraenhansen
Copy link
Collaborator

@kraenhansen kraenhansen commented May 17, 2025

Merging this PR will:

  • Delete the hermes clone using async fs operations
  • Make the React Native directory resolve relative to the app package root when patching JSI from our patched Hermes.
  • Add the fallback entrypoint for our "babel-plugin" to the "files" in the package.json.
  • Add react-native@0.79.2 as a supported peer dependency (because its Hermes tag hasn't changed since 0.79.1).

@kraenhansen kraenhansen self-assigned this May 17, 2025
Copy link

changeset-bot bot commented May 17, 2025

⚠️ No Changeset found

Latest commit: 93c3c64

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kraenhansen kraenhansen force-pushed the kh/napi-rs-banners branch from 954af4c to 3f8724e Compare May 17, 2025 21:32
@kraenhansen kraenhansen force-pushed the kh/fixup-outside-of-mono-repo branch 2 times, most recently from f2ae72c to 083ed40 Compare May 17, 2025 21:38
@kraenhansen kraenhansen changed the base branch from kh/napi-rs-banners to kh/weak-node-api-injection May 17, 2025 21:38
@kraenhansen kraenhansen added the Linking 🔗 Discovering and copying prebuilds from packages into the host label May 17, 2025
Base automatically changed from kh/weak-node-api-injection to main May 19, 2025 14:33
@kraenhansen kraenhansen force-pushed the kh/fixup-outside-of-mono-repo branch from 083ed40 to 911abe2 Compare May 19, 2025 14:36
@kraenhansen kraenhansen requested a review from mani3xis May 19, 2025 15:00
@kraenhansen kraenhansen force-pushed the kh/fixup-outside-of-mono-repo branch from 911abe2 to 4c9d21e Compare May 21, 2025 04:27
Copy link
Contributor

@matthargett matthargett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments/suggestions. did you test on a Android app non-monorepo in a Windows cmd/powershell enviroment?

Co-authored-by: Matt Hargett <plaztiksyke@gmail.com>
@kraenhansen
Copy link
Collaborator Author

did you test on a Android app non-monorepo in a Windows cmd/powershell enviroment?

I did not and I agree, we should probably do a pass trying consume this from Windows (soon -ish).

@kraenhansen kraenhansen merged commit 53173c3 into main May 23, 2025
3 checks passed
@kraenhansen kraenhansen deleted the kh/fixup-outside-of-mono-repo branch May 23, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Linking 🔗 Discovering and copying prebuilds from packages into the host

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants