-
Notifications
You must be signed in to change notification settings - Fork 4
Minor fixes from using package outside of a mono-repo #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
954af4c
to
3f8724e
Compare
f2ae72c
to
083ed40
Compare
083ed40
to
911abe2
Compare
911abe2
to
4c9d21e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor comments/suggestions. did you test on a Android app non-monorepo in a Windows cmd/powershell enviroment?
Co-authored-by: Matt Hargett <plaztiksyke@gmail.com>
I did not and I agree, we should probably do a pass trying consume this from Windows (soon -ish). |
Merging this PR will:
react-native@0.79.2
as a supported peer dependency (because its Hermes tag hasn't changed since0.79.1
).