First class support for generic loader and definitions #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removing calmjs.parse as that is already required by calmjs. - Require the minimum version needed for the loader registry support.
- Encapsulate the whole related process into a single method.
- Due to how the webpack specific way does conflict with the existing prefix based usage framework, provide a specific webpack version that can effect webpack specific configurations. Commit amended to support calmjs/calmjs@20d8c2b455
- Provide the base fragments that are needed so that the pieces to produce the final configuration for webpack can be done.
- This is to ensure forward compatibility, and ensure that the loaderplugin additions do not conflict with the tests. - Also just isolate this out to make the intent clear.
- Minor reworking of the test environment setup for webpack, and add comments on how/why the environment were set up like such. - Provide a separate function to set up the style test cases. - Add the loaderplugin filter function to the Toolchain.assemble method, to enable the support of prefixless imports of resources exported by Python packages through the WebpackModuleLoader registry
- Provide the full solution that provides the complete integration of webpack loader support. - For the integration testing, make use of the calmjs.dev integration tests for ensuring that the styles are applied and that the additional module.rules does not interfere with coverage reporting (and vice versa).
- So that they may be used.
- Also add a note about that module name, because it might be worthwhile
to actually allow the standard definition, i.e. defining the loader
by the full name (e.g. style -> style-loader), so that
[calmjs.module.webpackloader]
style-loader!css-loader = styles[css]
should be possible.
metatoaster
force-pushed
the
loader_module
branch
2 times, most recently
from
5aaabc3 to
744689d
Compare
- Such that the correct/intended Node.js package be located, especially for the most explicit/correct definition using the -loader suffix.
- Fix the class typo. - Also ensure that the coverage data get written explicitly to where the build directory is.
- Show that the .tests.webpackloader entries are added to the karma and webpack configuration correctly. - Also do another standalone artifact test to ensure this combination is also supported.
- Correct the various test cases that were affected before this version. - Also the fact that calmjs.dev-2.2.0 introduced some vital changes that make the usage of the testing much simpler for end users warrants this version bump.
metatoaster
force-pushed
the
loader_module
branch
3 times, most recently
from
8e8ff99 to
bb3f2aa
Compare
- Also bumped OS X dependencies.
metatoaster
force-pushed
the
loader_module
branch
from
bb3f2aa to
9248cb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate the
calmjs-3.3.0loader module registries along with an extended registry class to support webpackmodule.rulesmethod of defining loaders. This is still work in progress (although mostly done) as the full change is pending on the release ofcalmjs.dev-2.2.0so that the test registries for loaders will be resolved correctly.Also the changelog entry will need further completion as it is missing a few pieces of key information and notes (like the correction to the karma webpack configuration).