fix duplicate sys msg & consecutive user in ass agent memory #424
Conversation
ocss884
added
Model
camel/societies/role_playing.py
Outdated
| "Now start to give me instructions one by one. " | ||
| "Only reply with Instruction and Input.")) | ||
| role_name=self.assistant_sys_msg.role_name, content=first_msg) | ||
| user_msg = BaseMessage.make_user_message( |
There was a problem hiding this comment.
It seems we are still repeating the system message for the assistant agent, right?
There was a problem hiding this comment.
It seems we are still repeating the system message for the assistant agent, right?
No, actually only the content here matters. assistant_sys_msg.role_name is more of a placeholder since during step each agent knows how to recode the role of incoming message correctly. I just keep the originally code of this part (well it could be confusing I should say).
There was a problem hiding this comment.
I meant this PR seems to be not yet solving the consecutive user msg bug.
There was a problem hiding this comment.
I meant this PR seems to be not yet solving the consecutive user msg bug.
I'm so sorry about my mistake. It should be fixed now after deleting the .step.
dosubot
bot
added
the
size:M
dosubot
bot
added
size:L
…l-ai/camel into fix/init-chat-duplicate-msg
…i#424) Co-authored-by: lig <guohao.li@kaust.edu.sa> Co-authored-by: Guohao Li <lightaime@gmail.com>
Description
Pls read #421 for description
Motivation and Context
close #421
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Implemented Tasks
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!