Skip to content

Conversation

@Hook25
Copy link
Collaborator

@Hook25 Hook25 commented Jul 8, 2025

Description

When provisioning from source, the Checkbox venv will fill itself of a recursive rabbithole of build/lib/build. This is due to a misconfiguration of the setuptool finder. This fixes it

Resolved issues

N/A

Documentation

N/A

Tests

Tested locally, it doesn't happen anymore

Hook25 added 2 commits July 8, 2025 16:59
This is actually the default behaviour but we loose it because
we have to exclude manually the debian directory
@codecov
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.60%. Comparing base (5285d8f) to head (a87c339).
⚠️ Report is 103 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2010      +/-   ##
==========================================
- Coverage   50.60%   50.60%   -0.01%     
==========================================
  Files         384      384              
  Lines       41180    41184       +4     
  Branches     7642     7643       +1     
==========================================
+ Hits        20841    20842       +1     
- Misses      19592    19594       +2     
- Partials      747      748       +1     
Flag Coverage Δ
checkbox-ng 70.31% <ø> (-0.02%) ⬇️
checkbox-support 63.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@fernando79513 fernando79513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1!

@fernando79513 fernando79513 merged commit 8626b53 into main Jul 8, 2025
29 checks passed
@fernando79513 fernando79513 deleted the build_lib_rabbithole branch July 8, 2025 15:20
mreed8855 pushed a commit that referenced this pull request Jul 30, 2025
* Exclude build and dist from the finder

This is actually the default behaviour but we loose it because
we have to exclude manually the debian directory

* Ditto for checkbox support
mreed8855 pushed a commit that referenced this pull request Jul 31, 2025
* Exclude build and dist from the finder

This is actually the default behaviour but we loose it because
we have to exclude manually the debian directory

* Ditto for checkbox support
bladernr pushed a commit that referenced this pull request Aug 28, 2025
* Exclude build and dist from the finder

This is actually the default behaviour but we loose it because
we have to exclude manually the debian directory

* Ditto for checkbox support
stanley31huang pushed a commit that referenced this pull request Oct 3, 2025
* Exclude build and dist from the finder

This is actually the default behaviour but we loose it because
we have to exclude manually the debian directory

* Ditto for checkbox support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants