Copy all packages and catch those that couldn't be copied (infra)

[Hook25]

Description

The strategy of trying to infer what packages are to be copied has two disadvantages:

• Doens't copy non-checkbox packages
• Doens't work if we pass validation the day the series is disabled (race condition, we may build the package and fail once we try to copy it)

This leads to partial beta releases, like the one we just had. This fixes the issue by simply skipping the copy actions that fails with the error that the target build is outdated.

Resolved issues

Fixes: https://warthogs.atlassian.net/browse/CHECKBOX-1977

Documentation

N/A

Tests

Updated the tests and fixed the current release with this fix

[codecov]

Codecov Report

❌ Patch coverage is 85.71429% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.04%. Comparing base (56dcd35) to head (e7671e1).
⚠️ Report is 100 commits behind head on main.

Files with missing lines	Patch %	Lines
tools/release/lp_copy_packages.py	81.81%	1 Missing and 1 partial ⚠️
tools/release/lp_update_recipe.py	88.23%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2017      +/-   ##
==========================================
+ Coverage   51.03%   51.04%   +0.01%     
==========================================
  Files         385      385              
  Lines       41507    41524      +17     
  Branches     7712     7716       +4     
==========================================
+ Hits        21184    21197      +13     
- Misses      19563    19564       +1     
- Partials      760      763       +3     

Flag	Coverage Δ
release-tools	81.06% <85.71%> (-0.21%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[fernando79513]

I guessed there could be a race condition, though I didn't guess the exact reason, XD.

I like this approach better. There is just one small comment. Since now we are copying all the packages (not only the checkbox ones), there could be a chance that we remove a package from the source PPA, and it will remain in the destination PPA, forever.

I don't think this is a big issue, but it would be great to include a comparison of the packages in the source PPA and the destination PPA for debugging purposes, as we have the output of the packages we have successfully copied.

[Hook25]

I've updated the code to also check if version are outdate and remove them from the desired list. AFAIK you can't remove packages from a PPA, so I'm not sure your comment applies. Still, we've never done something like that, I don't think it applies here

[fernando79513]

It seems it is possible to remove packages from a PPA:

But as I said, it is not a major issue. If we decide to get rid of a deprecated package for any reason, we could do it manually.

[fernando79513]

LGTM+1!

[Hook25]

ngl, I'm unsure about what that button does and how to get to it regularly (when copies didn't fail).