Rollback to provisioned before installing in reused containers #557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done because if a test run is interrupted midway through, reusing the container will actually break it (because the old run is still in the container files, leading checkbox to prompt for a restart/drop)
Hook25
force-pushed
the
fix_mb_reuse_provisioning_rollback
branch
from
d66d5b0 to
e992c80
Compare
kissiel
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is done because if a test run is interrupted midway through, reusing the container will actually break it (because the old run is still in the container files, leading checkbox to prompt for a restart/drop)
Resolved issues
N/A
Documentation
N/A
Tests
This was tested by running metabox with a container to update, one to create and one that should be updated but it is in an invalid state (missing provisioned)