CHECKBOX-345: No longer ignore virtual watchdog #561
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The problem is that watchdog/detect failed to find any watchdog, any yet passed the subsequent trigger-system-reset test.
This is because udevadm ignores the virtual watchdog by default (the reason behind it is that there used to be a machine with a large number of virtual watchdogs: https://code.launchpad.net/~jocave/checkbox-support/+git/checkbox-support/+merge/395442)
After discussions with Pierre, Jonathan and Slyvain, since the situation is different, the virtual watchdog can no longer be ignored (checked several latest IoT and PC projects, some machines do not have physical watchdog, which using virtual watchdog to run the trigger-system-reset test). And it is necessary to use the udevadm log of 202109-29473 as a unit test to verify whether the virtual watchdog will be included in the list after modification.
This change will affect the expected results of the udevadm_data unit tests (e.g. Lenovo E431, need to increase the number of expected devices from 68 to 100, because the virtual watchdog is now also included in the calculation)
Resolved issues
https://warthogs.atlassian.net/browse/CHECKBOX-345
Tests
Run
./setup.py testunder checkbox/checkbox-support/