Skip to content

Conversation

@diohe0311
Copy link
Contributor

@diohe0311 diohe0311 commented Jun 15, 2023

Description

The problem is that watchdog/detect failed to find any watchdog, any yet passed the subsequent trigger-system-reset test.
This is because udevadm ignores the virtual watchdog by default (the reason behind it is that there used to be a machine with a large number of virtual watchdogs: https://code.launchpad.net/~jocave/checkbox-support/+git/checkbox-support/+merge/395442)

After discussions with Pierre, Jonathan and Slyvain, since the situation is different, the virtual watchdog can no longer be ignored (checked several latest IoT and PC projects, some machines do not have physical watchdog, which using virtual watchdog to run the trigger-system-reset test). And it is necessary to use the udevadm log of 202109-29473 as a unit test to verify whether the virtual watchdog will be included in the list after modification.

This change will affect the expected results of the udevadm_data unit tests (e.g. Lenovo E431, need to increase the number of expected devices from 68 to 100, because the virtual watchdog is now also included in the calculation)

Resolved issues

https://warthogs.atlassian.net/browse/CHECKBOX-345

Tests

Run ./setup.py test under checkbox/checkbox-support/

@diohe0311 diohe0311 changed the title CHECKBOX-345: No longer ignore virtual watchdo CHECKBOX-345: No longer ignore virtual watchdog Jun 15, 2023
@diohe0311 diohe0311 marked this pull request as draft June 15, 2023 03:20
@diohe0311 diohe0311 marked this pull request as ready for review June 15, 2023 03:37
Copy link
Collaborator

@pieqq pieqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good job!

I was curious as to why we needed

        if device.category == "WATCHDOG":
            return False

but it's because below, there is a generic condition that ignores all the devices without any vendor or product info, which is the case for the watchdog devices...

Thanks for adding the unit tests and modifying the existing ones!

@pieqq pieqq merged commit bbad19c into main Jun 20, 2023
@pieqq pieqq deleted the CHECKBOX-345 branch June 20, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants