Closed
Conversation
Member
What do you see being refined about the component's API? |
Contributor
Author
|
Make it configurable for plausible usage, ie, the width, the height. Rework the name of the props, the defaults. |
5 tasks
Member
|
Closing in favor of #325 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
A work-in progress PR displaying a PoC to leverage
<svg><use>as a way to consume SVG sprites.The trick of the sprites is to include several groups in the svg, and display only the targetted one (
sprite.svg#my-icon-name).A second minor feature is included : a PoC of SVG theming using intent colors. The last story,
Illustrationdisplays this concept.In case we would like to proceed with this approach, it would only be necessary to refine the API of the component.
A third minor feature is included : the ability to programatically animate strokes of SVGs.
QA
Code Q/A :
sprite.svgusing the source diff.Visual Q/A :
PR readiness check
Feature 🎁,Breaking Change 💣,Bug 🐛,Documentation 📝,Maintenance 🔨.package.json:checkandcheck:fix.build.Screenshots
[if relevant, include a screenshot or screen capture]