Skip to content

Conversation

marceloneppel
Copy link
Member

@marceloneppel marceloneppel commented Oct 8, 2025

Issue

The charm does not remove the old revisions of a secret after updating it.

Solution

Port of canonical/postgresql-operator#1195.

Implement the secret-remove event handler.

Checklist

  • I have added or updated any relevant documentation.
  • I have cleaned any remaining cloud resources from my accounts.

Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
@marceloneppel marceloneppel added the not bug or enhancement PR is not 'bug' or 'enhancement'. For release notes label Oct 8, 2025
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.38%. Comparing base (6317a84) to head (ad85559).
⚠️ Report is 1 commits behind head on 16/edge.

❌ Your project status has failed because the head coverage (67.38%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           16/edge    #1128      +/-   ##
===========================================
+ Coverage    67.34%   67.38%   +0.04%     
===========================================
  Files           18       18              
  Lines         3947     3952       +5     
  Branches       564      564              
===========================================
+ Hits          2658     2663       +5     
  Misses        1116     1116              
  Partials       173      173              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marceloneppel marceloneppel changed the title Remove secret's old revision [DPE-8498] Remove secret's old revision Oct 8, 2025
@marceloneppel marceloneppel marked this pull request as ready for review October 8, 2025 18:45
@marceloneppel marceloneppel merged commit 9e0c39f into 16/edge Oct 9, 2025
282 of 296 checks passed
@marceloneppel marceloneppel deleted the remove-secret-old-revision-16 branch October 9, 2025 11:29
marceloneppel added a commit that referenced this pull request Oct 13, 2025
This reverts commit 9e0c39f.

Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Libraries: Out of sync not bug or enhancement PR is not 'bug' or 'enhancement'. For release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants