Skip to content

Conversation

@marceloneppel
Copy link
Member

@marceloneppel marceloneppel commented Nov 3, 2025

Issue

Solution

Checklist

  • I have added or updated any relevant documentation.
  • I have cleaned any remaining cloud resources from my accounts.

…efresh is not ready

Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

❌ Patch coverage is 48.14815% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.98%. Comparing base (46eac97) to head (5a96367).
⚠️ Report is 1 commits behind head on refresh-v3.

Files with missing lines Patch % Lines
src/charm.py 36.84% 8 Missing and 4 partials ⚠️
src/backups.py 75.00% 1 Missing and 1 partial ⚠️

❌ Your project status has failed because the head coverage (65.98%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@              Coverage Diff               @@
##           refresh-v3    #1156      +/-   ##
==============================================
+ Coverage       65.88%   65.98%   +0.10%     
==============================================
  Files              18       18              
  Lines            3904     3904              
  Branches          567      568       +1     
==============================================
+ Hits             2572     2576       +4     
+ Misses           1148     1143       -5     
- Partials          184      185       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
…est is already active

Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
@marceloneppel marceloneppel changed the title Reorder call to refresh logic and don't immediatelly exit hook when r… Reorder call to refresh logic and don't immediatelly exit hook when refresh is not ready Nov 19, 2025
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
@marceloneppel marceloneppel marked this pull request as ready for review November 19, 2025 19:47
@marceloneppel marceloneppel merged commit 86860f1 into refresh-v3 Nov 19, 2025
69 of 75 checks passed
@marceloneppel marceloneppel deleted the refresh-v3-reorder branch November 19, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants