Improve error-handling when failing to create a S3 backup #1280
Description
When a backup fails, error message is not appended in debug-log
Steps to reproduce
juju run postgresql/leader -- create-backup
Expected behavior
- When running the create-backup action
Failed to backup PostgreSQL with error: <CONTENT OF THE ERROR MESSAGE FROM S3>
- When checking debug-log:
**unit-postgresql-0: 07:11:59 ERROR unit.postgresql/0.juju-log backups:Backup failed: Failed to backup PostgreSQL with error:** : <CONTENT OF THE ERROR MESSAGE FROM S3>
Actual behavior
No error message appended. The fact the line ends with a : makes me think we are supposed to append the S3 error message.
juju run postgresql/0 -- create-backup
Action id 14 failed: Failed to backup PostgreSQL with error:
debug-log: Same, no error message appended backups:Backup failed: Failed to backup PostgreSQL with error:
unit-postgresql-0: 07:11:58 ERROR unit.postgresql/0.juju-log backups:
unit-postgresql-0: 07:11:58 INFO unit.postgresql/0.juju-log backups:Uploading content to bucket=ddev-postgresql-backup, path=backup/ddev-postgresql.postgresql/20251107-071158F/backup.log
**unit-postgresql-0: 07:11:59 ERROR unit.postgresql/0.juju-log backups:Backup failed: Failed to backup PostgreSQL with error:**
unit-postgresql-0: 07:12:01 WARNING unit.postgresql/0.juju-log tracing:charm tracing buffer exceeds max history length (100 events)
unit-postgresql-0: 07:12:04 WARNING unit.postgresql/0.juju-log tracing:charm tracing buffer exceeds max history length (100 events)
Versions
OS 24.04
Juju 3.6.11
Postgresql 16/stable (rev 952)
Additional information
Could this issue come from the fact the error message is too verbose and juju cannot append it ?
unit.postgresql/0.juju-log tracing:charm tracing buffer exceeds max history length (100 events)
backup.log file retrieved using command-line: https://pastebin.ubuntu.com/p/PQN3DD5CTp/