-
Notifications
You must be signed in to change notification settings - Fork 27
[DPE-7379] custom username #1100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 16/edge #1100 +/- ##
===========================================
- Coverage 65.09% 64.61% -0.49%
===========================================
Files 17 17
Lines 4277 4329 +52
Branches 654 667 +13
===========================================
+ Hits 2784 2797 +13
- Misses 1318 1351 +33
- Partials 175 181 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| def _on_relation_broken(self, event: RelationBrokenEvent) -> None: | ||
| """Correctly update the status.""" | ||
| self.update_username_mapping(event.relation.id, None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As is the oversee_users method will not delete custom usernames, since it cannot guess them and the relation should already be terminated. That means that re-relating with the same username will error out (the user already exists). We will need to port the logic for user deletion from k8s.
marceloneppel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Port of canonical/postgresql-k8s-operator#1060
Postgresql side of custom username implementation based on DA-176.
Checklist