[DPE-8550] Check juju version before removing revision #1214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1214 +/- ##
==========================================
+ Coverage 75.73% 75.79% +0.06%
==========================================
Files 16 16
Lines 4170 4173 +3
Branches 629 630 +1
==========================================
+ Hits 3158 3163 +5
+ Misses 792 790 -2
Partials 220 220 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dragomirp
force-pushed
the
revision-removal-version-check
branch
from
90ed72b to
9b6db1d
Compare
marceloneppel
approved these changes
Oct 10, 2025
There was a problem hiding this comment.
LGTM! Thanks, Dragomir.
I tested this PR on the following Juju versions:
- 3.6.11 (built from commit 37e3e7fec0dd8f287e55f03b4055bad2a927697e - coming from juju/juju#20796 - mentioned on #1195 (comment)) - correctly removes the previous secret revision.
- 3.6.9 - correctly skip previous secret revision removal.
2 tasks
taurus-forever
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't remove revision unless on safe Juju version.
Checklist