[DPE-1712] Enabled the user to fix network issues and rerun stanza related hooks #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #164 +/- ##
==========================================
+ Coverage 80.30% 80.37% +0.07%
==========================================
Files 8 8
Lines 1589 1595 +6
Branches 244 246 +2
==========================================
+ Hits 1276 1282 +6
Misses 274 274
Partials 39 39
|
dragomirp
approved these changes
Jun 15, 2023
…ut-errors-resolution
BON4
pushed a commit
to BON4/postgresql-operator
that referenced
this pull request
Apr 23, 2024
github-actions bot
added a commit
to canonical/test-runners-2-is-arm64-postgresql-operator
that referenced
this pull request
Sep 4, 2024
github-actions bot
added a commit
to canonical/test-runners-2-is-x64-postgresql-operator
that referenced
this pull request
Sep 5, 2024
github-actions bot
added a commit
to canonical/test-runners-2-github-x64-postgresql-operator
that referenced
this pull request
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The charm doesn't recovers automatically from a blocked state due to connection blocked by firewall rules after they are fixed neither allow the user to do some action to fix the blocked status.
Solution
Instead of setting a blocked status when any operation related to the stanza happens, raise an error, which enables the user to call
juju resolveafter the network issue is fixed.This was changed in three different places in case the connection is blocked in specific protocols, allowing one operation but timing out in the next one.
Closes #129.