[DPE-8276] Add unit tests #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
dragomirp
reviewed
Sep 3, 2025
| @@ -0,0 +1 @@ | |||
| no-binary = false | |||
There was a problem hiding this comment.
@taurus-forever do we need to build from source for this repo? Artefacts released should only be the library itself.
dragomirp
approved these changes
Sep 3, 2025
dragomirp
reviewed
Sep 3, 2025
pyproject.toml
Outdated
Comment on lines
11
to
12
| {name = "Dragomir Penev", email = "dragomir.penev@canonical.com"}, | ||
| {name = "Marcelo Henrique Neppel", email = "marcelo.neppel@canonical.com"} |
There was a problem hiding this comment.
Should we set the data-platform email here?
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes, we set the maintainers for charms to Canonical Data Platform, we should most probably do the same here.
There was a problem hiding this comment.
Thanks, @dragomirp! I updated it on 60d378c.
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
There are no unit tests for the migrated PostgreSQL charm library code.
Solution
Copy the unit tests from the K8s charm repository and adapt them to the V1 code (by removing mentions to the admin role, which doesn't exist for PG 16).
Also, some additional files were added to allow developers to run the unit tests.