[MISC] Increase coverage #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (40.64%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## 16/edge #9 +/- ##
===========================================
+ Coverage 32.21% 40.64% +8.42%
===========================================
Files 3 3
Lines 776 780 +4
Branches 91 92 +1
===========================================
+ Hits 250 317 +67
+ Misses 518 448 -70
- Partials 8 15 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dragomirp
commented
Sep 6, 2025
There was a problem hiding this comment.
Linting for the tests only. We have to keep 3.8 compatibility for PGB VM charm, but there's no need to also keep 3.8 support for the tests.
dragomirp
commented
Sep 6, 2025
Comment on lines
-44
to
-46
| exclude_lines = [ | ||
| "logger\\.debug" | ||
| ] |
There was a problem hiding this comment.
No need to exclude as we bump coverage.
dragomirp
commented
Sep 6, 2025
dragomirp
requested review from
a team,
marceloneppel and
taurus-forever
and removed request for
a team
taurus-forever
approved these changes
Sep 8, 2025
marceloneppel
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist