-
Notifications
You must be signed in to change notification settings - Fork 8
DINC0500664 : Multi level entity fix #341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog 1.5.0 for Release branch
updated the Release branch (Release_v1.5.0)
updated the version of our plugin to 1.5.0
sdm/src/main/java/com/sap/cds/sdm/handler/applicationservice/SDMCreateAttachmentsHandler.java
Show resolved
Hide resolved
...src/main/java/com/sap/cds/sdm/handler/applicationservice/helper/AttachmentsHandlerUtils.java
Show resolved
Hide resolved
...src/main/java/com/sap/cds/sdm/handler/applicationservice/helper/AttachmentsHandlerUtils.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/sap/cds/sdm/handler/applicationservice/helper/AttachmentsHandlerUtils.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/sap/cds/sdm/handler/applicationservice/helper/AttachmentsHandlerUtils.java
Outdated
Show resolved
Hide resolved
sdm/src/main/java/com/sap/cds/sdm/handler/common/SDMApplicationHandlerHelper.java
Show resolved
Hide resolved
yashmeet29
reviewed
Oct 24, 2025
...src/main/java/com/sap/cds/sdm/handler/applicationservice/helper/AttachmentsHandlerUtils.java
Outdated
Show resolved
Hide resolved
yashmeet29
reviewed
Oct 24, 2025
...src/main/java/com/sap/cds/sdm/handler/applicationservice/helper/AttachmentsHandlerUtils.java
Outdated
Show resolved
Hide resolved
yashmeet29
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where Save handler and Link related methods weren't working if the attachments aspect wasn't a direct composition on the Root entity, but rather a nested entity inside the Root entity
Leading application changes PR (Develop deploy) : #339
Leading application changes PR (Local deploy) : #340
Type of change
Checklist before requesting a review
Integration tests
Multitenancy job : https://github.com/cap-java/sdm/actions/runs/18743590582/job/53465517478