Skip to content

fix: Correctly retrieve appId from the VCAP_APPLICATION #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 2, 2025
+8 −2
Merged

fix: Correctly retrieve appId from the VCAP_APPLICATION #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f7aa38b
fix: Correctly retrieve `appId` from the `VCAP_APPLICATION` environme…
sjvans Sep 2, 2025
fd6540f
Merge branch 'main' into fix-appId
sjvans Sep 2, 2025
389b81f
Merge branch 'main' into fix-appId
simeongelovski Sep 2, 2025
a16916c
Update CHANGELOG.md
sjvans Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).
The format is based on [Keep a Changelog](http://keepachangelog.com/).

## Version 1.0.2 - tbd

### Fixed

- Correctly retrieve `appId` from the `VCAP_APPLICATION` environment variable

## Version 1.0.1 - 2025-08-05

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@cap-js/audit-logging",
"version": "1.0.1",
"version": "1.0.2",
"description": "CDS plugin providing integration to the SAP Audit Log service as well as out-of-the-box personal data-related audit logging based on annotations.",
"repository": "cap-js/audit-logging",
"author": "SAP SE (https://www.sap.com)",
Expand Down
2 changes: 1 addition & 1 deletion srv/log2alsng.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ module.exports = class AuditLog2ALSNG extends AuditLogService {
this._vcap = JSON.parse(process.env.VCAP_SERVICES || '{}')
this._userProvided = this._vcap['user-provided']?.find(obj => obj.tags.includes('auditlog-ng')) || {}
if (!this._userProvided.credentials) throw new Error('No credentials found for SAP Audit Log Service NG')
this._vcapApplication = this._vcap['VCAP_APPLICATION'] || {}
this._vcapApplication = JSON.parse(process.env.VCAP_APPLICATION || '{}')
}

async init() {
Expand Down