cds 9: task queue #1790
Merged
cds 9: task queue #1790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjvans
reviewed
May 19, 2025
sjvans
reviewed
May 19, 2025
node.js/queue.md
Outdated
| - `storeLastError` (default `true`): Specifies if error information of the last failed emit should be stored in the tasks table. | ||
| - `parallel` (default `true`): Specifies if messages are sent in parallel (faster but the order isn't guaranteed). | ||
| - `timeout` (default `"1h"`): The time after which a message with `status = "processing"` can be processed again. Only for `legacyLocking = false`. | ||
| - `legacyLocking` (default `true`): If set to `false`, database locks are only used to set the status of the message to `processing` to prevent long-kept database locks. This is recommended but incompatible for parallel usage with `@sap/cds^8` instances. |
Contributor
There was a problem hiding this comment.
What is recommended? The default or setting it to false?
Contributor
There was a problem hiding this comment.
setting it to false. however, can only be done if all task runners do so (prerequisite: they all must be on cds9)
Contributor
|
my review: #1878 |
Co-authored-by: Dr. David A. Kunz <david.kunz@sap.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
|
@renejeglinsky @smahati ready from our side |
renejeglinsky
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only for cds 9