Skip to content

Issue 439 #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2025
Merged

Issue 439 #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions contracts/vault/Vault.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,11 @@ abstract contract Vault is
{
uint256 fee;
(amountOut, fee) = getBurnAmount(_asset, _amountIn);

_burn(msg.sender, _amountIn);

divest(_asset, amountOut + fee);

VaultLogic.burn(
getVaultStorage(),
MintBurnParams({
Expand All @@ -74,7 +78,6 @@ abstract contract Vault is
fee: fee
})
);
_burn(msg.sender, _amountIn);
}

/// @inheritdoc IVault
Expand All @@ -85,12 +88,15 @@ abstract contract Vault is
{
uint256[] memory fees;
(amountsOut, fees) = getRedeemAmount(_amountIn);

_burn(msg.sender, _amountIn);

uint256[] memory totalDivestAmounts = new uint256[](amountsOut.length);
for (uint256 i; i < amountsOut.length; i++) {
totalDivestAmounts[i] = amountsOut[i] + fees[i];
}

divestMany(assets(), totalDivestAmounts);

VaultLogic.redeem(
getVaultStorage(),
RedeemParams({
Expand All @@ -102,7 +108,6 @@ abstract contract Vault is
fees: fees
})
);
_burn(msg.sender, _amountIn);
}

/// @inheritdoc IVault
Expand Down