fix: remove internals from outbox api #2096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
David-Kunz
reviewed
Sep 18, 2025
| - `maxAttempts` (default `20`): The number of unsuccessful emits until the message is considered unprocessable. The message will remain in the database table! | ||
| - `parallel` (default `true`): Specifies if messages are sent in parallel (faster, but the order isn't guaranteed). | ||
| - `chunkSize` (default `10`): The number of messages that are read from the database table in one go. Only applies for `parallel !== false`. | ||
| - `storeLastError` (default `true`): Specifies whether error information of the last failed emit is stored in the tasks table. |
There was a problem hiding this comment.
Should we also rm storeLastError? Should we remove the legacyLocking completely and switch it to false?
David-Kunz
approved these changes
Sep 18, 2025
renejeglinsky
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.