Skip to content

fix: remove outdated default pool config #2100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 19, 2025
Merged

fix: remove outdated default pool config #2100

merged 2 commits into from
Sep 19, 2025

Conversation

sjvans
Copy link
Contributor

@sjvans sjvans commented Sep 18, 2025

No description provided.

@sjvans sjvans requested a review from BobdenOs September 18, 2025 09:33
@sjvans sjvans marked this pull request as ready for review September 18, 2025 09:33
@sjvans sjvans requested a review from smahati as a code owner September 18, 2025 09:33
@renejeglinsky
Copy link
Contributor

No mentioning of defaults anymore? How can one find the defaults being used? Probably cds env? I just couldn't find anything in my bookshop sample project.

@sjvans
Copy link
Contributor Author

sjvans commented Sep 19, 2025

No mentioning of defaults anymore? How can one find the defaults being used? Probably cds env? I just couldn't find anything in my bookshop sample project.

defaults are different for each db. via cds env doesn't work yet, unfortunately, but that's exactly where we want to go. and will add here once possible, of course.

@renejeglinsky renejeglinsky merged commit e292562 into main Sep 19, 2025
7 checks passed
@renejeglinsky renejeglinsky deleted the pool branch September 19, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@renejeglinsky renejeglinsky renejeglinsky approved these changes

@BobdenOs BobdenOs BobdenOs approved these changes

@smahati smahati Awaiting requested review from smahati smahati is a code owner

Assignees

No one assigned

Labels

merge before release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sjvans @renejeglinsky @BobdenOs