Skip to content

Conversation

@rjayasinghe
Copy link
Contributor

No description provided.

@rjayasinghe rjayasinghe requested a review from smahati as a code owner November 10, 2025 14:28
@rjayasinghe rjayasinghe self-assigned this Nov 10, 2025
@rjayasinghe rjayasinghe enabled auto-merge (squash) November 10, 2025 14:37
@rjayasinghe
Copy link
Contributor Author

@renejeglinsky @chgeo I thought we had AI reviews now?

@renejeglinsky renejeglinsky added the AI Review AI generated suggestions label Nov 11, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a supportive code review enhanced by AI assistance. These suggestions offer potential improvements and insights to consider, though they're recommendations rather than requirements. You have full control over which feedback to implement based on your project's needs and goals. The AI analysis is here to complement your expertise and help streamline your development process.
Model: claude-sonnet-4-20250514 | Prompt Tokens: 829 | Completion Tokens: 196

```yaml
cds.security.draftProtection.enabled: false
cds.security.authorization.draftProtection.enabled: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The configuration property path has been updated correctly from cds.security.draftProtection.enabled to cds.security.authorization.draftProtection.enabled. This change appears to be intentional and aligns with the hierarchical structure where draft protection is now properly nested under the authorization configuration.

@renejeglinsky
Copy link
Contributor

We have started that and you need to add the "AI Review" label. Let me know what you think about the suggestions and how it works. We're continuously improving it (hopefully).

@renejeglinsky renejeglinsky removed the AI Review AI generated suggestions label Nov 12, 2025
@renejeglinsky renejeglinsky merged commit d2ed1d6 into main Nov 12, 2025
9 checks passed
@renejeglinsky renejeglinsky deleted the fix_draft_protection_docu branch November 12, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants