-
Notifications
You must be signed in to change notification settings - Fork 140
adjust the draft protection snippet to the implementation #2196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@renejeglinsky @chgeo I thought we had AI reviews now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a supportive code review enhanced by AI assistance. These suggestions offer potential improvements and insights to consider, though they're recommendations rather than requirements. You have full control over which feedback to implement based on your project's needs and goals. The AI analysis is here to complement your expertise and help streamline your development process.
Model: claude-sonnet-4-20250514 | Prompt Tokens: 829 | Completion Tokens: 196
| ```yaml | ||
| cds.security.draftProtection.enabled: false | ||
| cds.security.authorization.draftProtection.enabled: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The configuration property path has been updated correctly from cds.security.draftProtection.enabled to cds.security.authorization.draftProtection.enabled. This change appears to be intentional and aligns with the hierarchical structure where draft protection is now properly nested under the authorization configuration.
|
We have started that and you need to add the "AI Review" label. Let me know what you think about the suggestions and how it works. We're continuously improving it (hopefully). |
No description provided.