Skip to content

Conversation

@DamienRobert
Copy link
Contributor

According to the doc one can pass a Hash or a Proc as a
:interaction_handler option, but only Hashes were wrapped into a
MappingInteractionHandler.

Fix this and add a test.

…dler

According to the doc one can pass a Hash or a Proc as a
:interaction_handler option, but only Hashes were wrapped into a
MappingInteractionHandler.

Fix this and add a test.
@capistrano-bot
Copy link

1 Warning
⚠️ Please update CHANGELOG.md with a description of your changes. If this PR is not a user-facing change (e.g. just refactoring), you can disregard this.

Here's an example of a CHANGELOG.md entry (place it immediately under the * Your contribution here! line):

* [#436](https://github.com/capistrano/sshkit/pull/436): Command: wrap a Proc interaction_handler into a MappingInteractionHandler - [@DamienRobert](https://github.com/DamienRobert)

Generated by 🚫 Danger

@DamienRobert
Copy link
Contributor Author

Ping? I did not add a changelog entry, but they are not in CHANGELOG.md anymore, so I don't know how to do it. Thanks!

@leehambley
Copy link
Member

leehambley commented Feb 23, 2020 via email

@DamienRobert
Copy link
Contributor Author

DamienRobert commented Feb 25, 2020

Hi Lee,
yes I am interested to meet those new "standards", but I am not sure what I should do?

Should I resend this PR with a 'PR: Bug Fix' title? I looked at the logs of the project but I am not sure I understand how it works.

@mattbrictson mattbrictson added the ✨ Feature Adds a new feature label Feb 29, 2020
@mattbrictson
Copy link
Member

Hi @DamienRobert , thanks for sticking with this PR. In terms of code quality and tests it looks good.

Each PR needs to have a label (that's the maintainer's responsibility) and a concise, descriptive PR title. The PR title is what gets included in the release notes. I'll tweak the title and then merge this in.

Thanks again for the PR and congrats on becoming a contributor to SSHKit!

@mattbrictson mattbrictson changed the title Command: wrap a Proc interaction_handler into a MappingInteractionHandler Allow a Proc to be used as in interaction_handler Feb 29, 2020
@mattbrictson mattbrictson changed the title Allow a Proc to be used as in interaction_handler Allow a Proc to be used as an interaction_handler Feb 29, 2020
@mattbrictson mattbrictson merged commit 810651d into capistrano:master Feb 29, 2020
@DamienRobert
Copy link
Contributor Author

Ok, I see, thanks for editing the PR title and merging this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ Feature Adds a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants