Skip to content

Add support for HTTPS upstream, make sure to pass the upstream Host header #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 4, 2025
Merged

Add support for HTTPS upstream, make sure to pass the upstream Host header #10

merged 2 commits into from
Jul 4, 2025

Conversation

@Niek
Copy link
Contributor

@Niek Niek commented Nov 28, 2024 •
edited
Loading

This PR adds:

  • Support for HTTPS upstream URLs, e.g. when reverse proxying a Cloudflare worker or some other site that is only accessible through HTTPS
  • Pass the upstream hostname in the Host header - so the upstream server doesn't need to support the additional reverse proxy hostname

githubsaturn
githubsaturn reviewed Dec 12, 2024
View reviewed changes
@githubsaturn githubsaturn merged commit bc9eeca into caprover:master Jul 4, 2025
@githubsaturn
Copy link
Contributor

Thanks!

1 similar comment
@githubsaturn
Copy link
Contributor

Thanks!

@githubsaturn githubsaturn mentioned this pull request Jul 5, 2025
Merged
@githubsaturn
Copy link
Contributor

I had to revert this due to this reported issue:
#13 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@githubsaturn githubsaturn githubsaturn left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Niek @githubsaturn