-
Notifications
You must be signed in to change notification settings - Fork 24
Fix helm chart template value and add pre-commit hooks #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
krithika369
merged 6 commits into
caraml-dev:main
from
krithika369:helm_chart_fixes_precommit
Aug 15, 2022
Merged
Fix helm chart template value and add pre-commit hooks #226
krithika369
merged 6 commits into
caraml-dev:main
from
krithika369:helm_chart_fixes_precommit
Aug 15, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krithika369
commented
Aug 8, 2022
romanwozniak
reviewed
Aug 8, 2022
romanwozniak
reviewed
Aug 8, 2022
romanwozniak
reviewed
Aug 8, 2022
romanwozniak
reviewed
Aug 8, 2022
romanwozniak
approved these changes
Aug 8, 2022
Collaborator
romanwozniak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sdk/samples/batch_job/ensembler.py
Outdated
| @@ -0,0 +1,63 @@ | |||
| import time | |||
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file committed unintentionally?
4fbab6f to
cf7408d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for this PR is to update the Helm template value in
infra/charts/turing/templates/_helpers.tplfor the postgres port used, which was missed from the PR that updated it earlier: #208The incorrect template expression did not cause any problems in the e2e tests because the port used was
5432, which is the same as the default port. Nonetheless, this PR corrects the mistake.In addition, the pre-commit tool has been integrated which helps automate some additional checks / actions when some files are being modified (eg: regenerating the Helm docs with changes to the chart values). The
.pre-commit-config.yamlfile has each of these hooks:maketarget)maketarget)Notes
README.md- contains the installation details for the pre-commit hooks. We must runmake setupon the repo once. Prior to this, it may be required to clear existing hooks (such as from husky, described further below) from the local environment, if the repo has already been cloned and used in the past.Makefile- adding the devsetuptarget. Corresponding setup targets from other Makefiles are now redundant and have been removed.ui/package.json- Removinghuskyandlint-stagedscripts and dev dependencies - these will now be covered by the commonpre-commithook. Having husky manage the hooks also conflicts with the pre-commit tool as they will both end up having to use the same git config valuecore.hooksPath.git addthe auto-modified files too. This behavior is the same for all pre-commit hooks and is apparently a conscious design decision (see functionality to add files to commit pre-commit/pre-commit#1099).filesfilter in the pre-commit hook definitions can limit the running of hooks based on the modified files (instead of running all hooks always).Most other modifications in this PR are auto-formatting fixes, particularly in the Python projects, from integrating black.