Skip to content

Conversation

@kush-savani
Copy link
Contributor

@kush-savani kush-savani commented Jun 24, 2022

Closes #2153
Closes #2160

Remove focus of combobox arrow button on tab key press
FYI: carbon component (react, vue, web component) have same behaviour which i implemented here.

Changelog

New

  • add tabindex property for combobox open/close button.

Changed

Before
ezgif-5-8f29027946

After
ezgif-5-13f92c8522

Remove focus of combobox arrow button
@kush-savani kush-savani requested a review from a team as a code owner June 24, 2022 12:43
@netlify
Copy link

netlify bot commented Jun 24, 2022

Deploy Preview for carbon-components-angular ready!

Name Link
🔨 Latest commit a74f705
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-angular/deploys/62bc9070a946480009ece994
😎 Deploy Preview https://deploy-preview-2169--carbon-components-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@zvonimirfras zvonimirfras enabled auto-merge June 29, 2022 17:48
@zvonimirfras zvonimirfras merged commit 1e8b280 into carbon-design-system:master Jun 29, 2022
@carbon-bot
Copy link
Contributor

🎉 This PR is included in version 4.59.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kush-savani kush-savani deleted the issue-2153 branch June 30, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Combobox focus does not act as expected when using tab keys Combobox open arrow has no keyboard focus

4 participants