refactor: reduce popover type duplication (#19656)

* refactor: reduce popover type duplication

* refactor(OverflowMenu): update v12 component types

Author: adamalston

packages/react/src/components/AILabel/index.tsx

@@ -22,6 +22,11 @@ import { mapPopoverAlign } from '../../tools/mapPopoverAlign';
 import { Undo } from '@carbon/icons-react';
 import { useId } from '../../internal/useId';
 import { deprecate } from '../../prop-types/deprecate';
+import type {
+  DeprecatedPopoverAlignment,
+  NewPopoverAlignment,
+  PopoverAlignment,
+} from '../Popover';
 
 export type AILabelContentProps = React.HTMLAttributes<HTMLSpanElement>;
 
@@ -102,31 +107,11 @@ AILabelActions.propTypes = {
  * Deprecated popover alignment values.
  * @deprecated Use NewPopoverAlignment instead.
  */
-export type DeprecatedAlignment =
-  | 'top-left'
-  | 'top-right'
-  | 'bottom-left'
-  | 'bottom-right'
-  | 'left-bottom'
-  | 'left-top'
-  | 'right-bottom'
-  | 'right-top';
-
-export type NewAlignment =
-  | 'top'
-  | 'bottom'
-  | 'left'
-  | 'right'
-  | 'top-start'
-  | 'top-end'
-  | 'bottom-start'
-  | 'bottom-end'
-  | 'left-end'
-  | 'left-start'
-  | 'right-end'
-  | 'right-start';
-
-export type Alignment = DeprecatedAlignment | NewAlignment;
+export type DeprecatedAlignment = DeprecatedPopoverAlignment;
+
+export type NewAlignment = NewPopoverAlignment;
+
+export type Alignment = PopoverAlignment;
 
 export interface AILabelProps {
   AILabelContent?: React.ReactNode;

packages/react/src/components/CodeSnippet/CodeSnippet.tsx

@@ -24,6 +24,11 @@ import copy from 'copy-to-clipboard';
 import { deprecate } from '../../prop-types/deprecate';
 import { usePrefix } from '../../internal/usePrefix';
 import deprecateValuesWithin from '../../prop-types/deprecateValuesWithin';
+import type {
+  DeprecatedPopoverAlignment,
+  NewPopoverAlignment,
+  PopoverAlignment,
+} from '../Popover';
 import { mapPopoverAlign } from '../../tools/mapPopoverAlign';
 
 const rowHeightInPixels = 16;
@@ -32,33 +37,11 @@ const defaultMaxExpandedNumberOfRows = 0;
 const defaultMinCollapsedNumberOfRows = 3;
 const defaultMinExpandedNumberOfRows = 16;
 
-export type DeprecatedCodeSnippetAlignment =
-  | 'top-left'
-  | 'top-right'
-  | 'bottom-left'
-  | 'bottom-right'
-  | 'left-bottom'
-  | 'left-top'
-  | 'right-bottom'
-  | 'right-top';
-
-export type NewCodeSnippetAlignment =
-  | 'top'
-  | 'bottom'
-  | 'left'
-  | 'right'
-  | 'top-start'
-  | 'top-end'
-  | 'bottom-start'
-  | 'bottom-end'
-  | 'left-end'
-  | 'left-start'
-  | 'right-end'
-  | 'right-start';
-
-export type CodeSnippetAlignment =
-  | DeprecatedCodeSnippetAlignment
-  | NewCodeSnippetAlignment;
+export type DeprecatedCodeSnippetAlignment = DeprecatedPopoverAlignment;
+
+export type NewCodeSnippetAlignment = NewPopoverAlignment;
+
+export type CodeSnippetAlignment = PopoverAlignment;
 
 export interface CodeSnippetProps {
   /**

packages/react/src/components/Copy/Copy.tsx

@@ -22,32 +22,17 @@ import { IconButton } from '../IconButton';
 import { noopFn } from '../../internal/noopFn';
 import deprecateValuesWithin from '../../prop-types/deprecateValuesWithin';
 import { mapPopoverAlign } from '../../tools/mapPopoverAlign';
+import type {
+  DeprecatedPopoverAlignment,
+  NewPopoverAlignment,
+  PopoverAlignment,
+} from '../Popover';
 
-export type DeprecatedCopyAlignment =
-  | 'top-left'
-  | 'top-right'
-  | 'bottom-left'
-  | 'bottom-right'
-  | 'left-bottom'
-  | 'left-top'
-  | 'right-bottom'
-  | 'right-top';
-
-export type NewCopyAlignment =
-  | 'top'
-  | 'bottom'
-  | 'left'
-  | 'right'
-  | 'top-start'
-  | 'top-end'
-  | 'bottom-start'
-  | 'bottom-end'
-  | 'left-end'
-  | 'left-start'
-  | 'right-end'
-  | 'right-start';
-
-export type CopyAlignment = DeprecatedCopyAlignment | NewCopyAlignment;
+export type DeprecatedCopyAlignment = DeprecatedPopoverAlignment;
+
+export type NewCopyAlignment = NewPopoverAlignment;
+
+export type CopyAlignment = PopoverAlignment;
 
 export interface CopyProps
   extends React.ButtonHTMLAttributes<HTMLButtonElement> {

packages/react/src/components/CopyButton/CopyButton.tsx

@@ -16,34 +16,17 @@ import { usePrefix } from '../../internal/usePrefix';
 import { noopFn } from '../../internal/noopFn';
 import deprecateValuesWithin from '../../prop-types/deprecateValuesWithin';
 import { mapPopoverAlign } from '../../tools/mapPopoverAlign';
+import type {
+  DeprecatedPopoverAlignment,
+  NewPopoverAlignment,
+  PopoverAlignment,
+} from '../Popover';
 
-export type DeprecatedCopyButtonAlignment =
-  | 'top-left'
-  | 'top-right'
-  | 'bottom-left'
-  | 'bottom-right'
-  | 'left-bottom'
-  | 'left-top'
-  | 'right-bottom'
-  | 'right-top';
-
-export type NewCopyButtonAlignment =
-  | 'top'
-  | 'bottom'
-  | 'left'
-  | 'right'
-  | 'top-start'
-  | 'top-end'
-  | 'bottom-start'
-  | 'bottom-end'
-  | 'left-end'
-  | 'left-start'
-  | 'right-end'
-  | 'right-start';
-
-export type CopyButtonAlignment =
-  | DeprecatedCopyButtonAlignment
-  | NewCopyButtonAlignment;
+export type DeprecatedCopyButtonAlignment = DeprecatedPopoverAlignment;
+
+export type NewCopyButtonAlignment = NewPopoverAlignment;
+
+export type CopyButtonAlignment = PopoverAlignment;
 
 export interface CopyButtonProps extends ButtonProps<'button'> {
   /**

packages/react/src/components/IconButton/index.tsx

@@ -15,6 +15,11 @@ import { usePrefix } from '../../internal/usePrefix';
 import ButtonBase from '../Button/ButtonBase';
 import deprecateValuesWithin from '../../prop-types/deprecateValuesWithin';
 import BadgeIndicator from '../BadgeIndicator';
+import type {
+  DeprecatedPopoverAlignment,
+  NewPopoverAlignment,
+  PopoverAlignment,
+} from '../Popover';
 import { mapPopoverAlign } from '../../tools/mapPopoverAlign';
 
 export const IconButtonKinds = [
@@ -26,33 +31,11 @@ export const IconButtonKinds = [
 
 export type IconButtonKind = (typeof IconButtonKinds)[number];
 
-export type DeprecatedIconButtonAlignment =
-  | 'top-left'
-  | 'top-right'
-  | 'bottom-left'
-  | 'bottom-right'
-  | 'left-bottom'
-  | 'left-top'
-  | 'right-bottom'
-  | 'right-top';
-
-export type NewIconButtonAlignment =
-  | 'top'
-  | 'bottom'
-  | 'left'
-  | 'right'
-  | 'top-start'
-  | 'top-end'
-  | 'bottom-start'
-  | 'bottom-end'
-  | 'left-end'
-  | 'left-start'
-  | 'right-end'
-  | 'right-start';
-
-export type IconButtonAlignment =
-  | DeprecatedIconButtonAlignment
-  | NewIconButtonAlignment;
+export type DeprecatedIconButtonAlignment = DeprecatedPopoverAlignment;
+
+export type NewIconButtonAlignment = NewPopoverAlignment;
+
+export type IconButtonAlignment = PopoverAlignment;
 
 export interface IconButtonProps
   extends React.ButtonHTMLAttributes<HTMLButtonElement> {

packages/react/src/components/OverflowMenu/next/index.tsx

@@ -14,6 +14,7 @@ import { useFeatureFlag } from '../../FeatureFlags';
 
 import { IconButton } from '../../IconButton';
 import { Menu } from '../../Menu';
+import type { PopoverAlignment } from '../../Popover';
 import mergeRefs from '../../../tools/mergeRefs';
 
 import { useId } from '../../../internal/useId';
@@ -63,15 +64,7 @@ interface OverflowMenuProps {
   /**
    * Specify how the trigger tooltip should be aligned.
    */
-  tooltipAlignment?:
-    | 'top'
-    | 'top-left'
-    | 'top-right'
-    | 'bottom'
-    | 'bottom-left'
-    | 'bottom-right'
-    | 'left'
-    | 'right';
+  tooltipAlignment?: PopoverAlignment;
 
   /**
    * Specify a DOM node where the Menu should be rendered in. Defaults to document.body.