Skip to content

Commit 0ff886d

Browse files
fix: remove deprecated ariaLabel prop (#18551)
* fix: remove deprecated ariaLabel prop * fix remove ariaLabel from type definition --------- Co-authored-by: Gururaj J <89023023+Gururajj77@users.noreply.github.com>
1 parent 6b4993b commit 0ff886d

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

packages/react/src/components/DataTable/DataTable.tsx

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,6 @@ export interface DataTableRenderProps<RowType, ColTypes extends any[]> {
133133
onExpand?: (e: React.MouseEvent<HTMLButtonElement>) => void;
134134
[key: string]: unknown;
135135
}) => {
136-
ariaLabel: string; // TODO Remove in v12
137136
['aria-label']: string;
138137
isExpanded: boolean;
139138
onExpand: (e: React.MouseEvent<HTMLButtonElement>) => void;
@@ -144,7 +143,6 @@ export interface DataTableRenderProps<RowType, ColTypes extends any[]> {
144143
row: DataTableRow<ColTypes>;
145144
[key: string]: unknown;
146145
}) => {
147-
ariaLabel: string; // TODO Remove in v12
148146
['aria-label']: string;
149147
disabled: boolean | undefined;
150148
isExpanded?: boolean;
@@ -165,7 +163,6 @@ export interface DataTableRenderProps<RowType, ColTypes extends any[]> {
165163
row: DataTableRow<ColTypes>;
166164
[key: string]: unknown;
167165
}) => {
168-
ariaLabel: string;
169166
'aria-label': string;
170167
checked?: boolean | undefined;
171168
disabled?: boolean | undefined;
@@ -520,7 +517,6 @@ class DataTable<RowType, ColTypes extends any[]> extends React.Component<
520517
: translationKeys.expandAll;
521518
return {
522519
...rest,
523-
ariaLabel: t(translationKey), // TODO: remove in v12
524520
'aria-label': t(translationKey),
525521
// Provide a string of all the expanded row id's, separated by a space.
526522
'aria-controls': rowIds.map((id) => `expanded-row-${id}`).join(' '),
@@ -588,7 +584,6 @@ class DataTable<RowType, ColTypes extends any[]> extends React.Component<
588584
// handler
589585
onExpand: composeEventHandlers([this.handleOnExpandRow(row.id), onClick]),
590586
isExpanded: row.isExpanded,
591-
ariaLabel: t(translationKey), // TODO remove in v12
592587
'aria-label': t(translationKey),
593588
'aria-controls': `expanded-row-${row.id}`,
594589
isSelected: row.isSelected,
@@ -649,7 +644,6 @@ class DataTable<RowType, ColTypes extends any[]> extends React.Component<
649644
]),
650645
id: `${this.getTablePrefix()}__select-row-${row.id}`,
651646
name: `select-row-${this.instanceId}`,
652-
ariaLabel: t(translationKey), // TODO remove in v12
653647
'aria-label': t(translationKey),
654648
disabled: row.disabled,
655649
radio: this.props.radio,
@@ -670,7 +664,6 @@ class DataTable<RowType, ColTypes extends any[]> extends React.Component<
670664

671665
return {
672666
...rest,
673-
ariaLabel: t(translationKey), // TODO remove in v12
674667
'aria-label': t(translationKey),
675668
checked,
676669
id: `${this.getTablePrefix()}__select-all`,

0 commit comments

Comments
 (0)