Skip to content

Commit 1c52669

Browse files
fix(page-header): remove stories (#19001)
* fix(page-header): remove stories * fix(tests): add skip
1 parent e6f60a6 commit 1c52669

File tree

3 files changed

+11
-8
lines changed

3 files changed

+11
-8
lines changed

e2e/components/PageHeader/PageHeader-test.avt.e2e.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,9 @@
99
import { expect, test } from '@playwright/test';
1010
import { visitStory } from '../../test-utils/storybook';
1111

12+
//TODO: update once stories are visible
1213
test.describe('@avt PageHeader', () => {
13-
test('@avt-default-state content', async ({ page }) => {
14+
test.skip('@avt-default-state content', async ({ page }) => {
1415
await visitStory(page, {
1516
component: 'PageHeader.Content',
1617
id: 'patterns-unstable-pageheader--content',

e2e/components/PageHeader/PageHeader-test.e2e.js

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,24 +11,27 @@ const { themes } = require('../../test-utils/env');
1111
const { snapshot } = require('../../test-utils/snapshot');
1212
const { snapshotStory, visitStory } = require('../../test-utils/storybook');
1313

14+
// TODO update once stories are visible
1415
test.describe('PageHeader', () => {
1516
themes.forEach((theme) => {
1617
test.describe(theme, () => {
17-
test('page header @vrt', async ({ page }) => {
18+
test.skip('page header @vrt', async ({ page }) => {
1819
await snapshotStory(page, {
1920
component: 'PageHeader',
2021
id: 'patterns-unstable-pageheader--content',
2122
theme,
2223
});
2324
});
24-
test('page header with contextual actions @vrt', async ({ page }) => {
25+
test.skip('page header with contextual actions @vrt', async ({
26+
page,
27+
}) => {
2528
await snapshotStory(page, {
2629
component: 'PageHeader',
2730
id: 'patterns-unstable-pageheader--content-with-contextual-actions',
2831
theme,
2932
});
3033
});
31-
test('page header with contextual actions and page actions @vrt', async ({
34+
test.skip('page header with contextual actions and page actions @vrt', async ({
3235
page,
3336
}) => {
3437
await snapshotStory(page, {
@@ -37,14 +40,14 @@ test.describe('PageHeader', () => {
3740
theme,
3841
});
3942
});
40-
test('page header with hero image @vrt', async ({ page }) => {
43+
test.skip('page header with hero image @vrt', async ({ page }) => {
4144
await snapshotStory(page, {
4245
component: 'PageHeader',
4346
id: 'patterns-unstable-pageheader--content-with-hero-image',
4447
theme,
4548
});
4649
});
47-
test('page header with icon @vrt', async ({ page }) => {
50+
test.skip('page header with icon @vrt', async ({ page }) => {
4851
await snapshotStory(page, {
4952
component: 'PageHeader',
5053
id: 'patterns-unstable-pageheader--content-with-icon',

packages/react/src/components/PageHeader/PageHeader.stories.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,7 @@ export default {
7878
PageHeaderHeroImage,
7979
PageHeaderTabBar,
8080
},
81-
// uncomment includeStories before merging so the stories aren't visible in prod
82-
// includeStories: [],
81+
includeStories: [],
8382
argTypes: {
8483
children: {
8584
control: false, // ReactNode props don't work in the controls pane

0 commit comments

Comments
 (0)