Commit 2b9c45c
fix: typescript declarations for Slider and SliderSkeleton (#20833)
* fix: typescript declarations for Slider and SliderSkeleton
Those components do not have a property named "propTypes",
but the declarations in Slider.d.ts and Slider.Skeleton.d.ts
claimed they did.
I think the problem happens because there's some magic that tries
to generate Typescript declarations based on the PropTypes, and
that is fragile. I followed the example of Row.tsx to avoid /
workaround that issue.
Fixes #20832.
* fix: tests
* fix: storybook
---------
Co-authored-by: Riddhi Bansal <41935566+riddhybansal@users.noreply.github.com>1 parent 2436a22 commit 2b9c45c
File tree
5 files changed
+8
-11
lines changed- packages/react/src/components/Slider
- __test__
5 files changed
+8
-11
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| |||
145 | 145 | | |
146 | 146 | | |
147 | 147 | | |
148 | | - | |
149 | | - | |
| 148 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | | - | |
| 12 | + | |
14 | 13 | | |
15 | 14 | | |
16 | 15 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
335 | 335 | | |
336 | 336 | | |
337 | 337 | | |
338 | | - | |
| 338 | + | |
339 | 339 | | |
340 | 340 | | |
341 | 341 | | |
| |||
1886 | 1886 | | |
1887 | 1887 | | |
1888 | 1888 | | |
| 1889 | + | |
| 1890 | + | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | | - | |
| 8 | + | |
10 | 9 | | |
11 | | - | |
12 | | - | |
0 commit comments