Skip to content

Commit 2b9c45c

Browse files
wkeeseriddhybansal
andauthored
fix: typescript declarations for Slider and SliderSkeleton (#20833)
* fix: typescript declarations for Slider and SliderSkeleton Those components do not have a property named "propTypes", but the declarations in Slider.d.ts and Slider.Skeleton.d.ts claimed they did. I think the problem happens because there's some magic that tries to generate Typescript declarations based on the PropTypes, and that is fragile. I followed the example of Row.tsx to avoid / workaround that issue. Fixes #20832. * fix: tests * fix: storybook --------- Co-authored-by: Riddhi Bansal <41935566+riddhybansal@users.noreply.github.com>
1 parent 2436a22 commit 2b9c45c

File tree

5 files changed

+8
-11
lines changed

5 files changed

+8
-11
lines changed

packages/react/src/components/Slider/Slider.Skeleton.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
*/
77

88
import PropTypes from 'prop-types';
9-
import React, { HTMLAttributes, useState } from 'react';
9+
import React, { HTMLAttributes, ReactNode, useState } from 'react';
1010
import cx from 'classnames';
1111
import { usePrefix } from '../../internal/usePrefix';
1212
import useIsomorphicEffect from '../../internal/useIsomorphicEffect';
@@ -145,5 +145,4 @@ SliderSkeleton.propTypes = {
145145
twoHandles: PropTypes.bool,
146146
};
147147

148-
export default SliderSkeleton;
149-
export { SliderSkeleton };
148+
export default SliderSkeleton as (props: SliderSkeletonProps) => ReactNode;

packages/react/src/components/Slider/Slider.stories.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@ import React, { useState } from 'react';
99

1010
import { WithLayer } from '../../../.storybook/templates/WithLayer';
1111

12-
import { SliderSkeleton } from '.';
13-
import { Slider } from './Slider';
12+
import { Slider, SliderSkeleton } from '.';
1413
import mdx from './Slider.mdx';
1514

1615
export default {

packages/react/src/components/Slider/Slider.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,7 @@ type State = {
335335
isRtl: boolean;
336336
};
337337

338-
export const Slider = (props: SliderProps) => {
338+
const Slider = (props: SliderProps) => {
339339
// TODO: Move destructured `props` from the IIFE to here.
340340

341341
const initialState: State = {
@@ -1886,3 +1886,5 @@ Slider.propTypes = {
18861886
*/
18871887
warnText: PropTypes.node,
18881888
};
1889+
1890+
export default Slider as (props: SliderProps) => ReactNode;

packages/react/src/components/Slider/__test__/Slider-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
*/
77

88
import React from 'react';
9-
import { Slider } from '../Slider';
9+
import Slider from '../Slider';
1010
import userEvent from '@testing-library/user-event';
1111
import { fireEvent, render, screen } from '@testing-library/react';
1212

packages/react/src/components/Slider/index.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,5 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8-
import { Slider } from './Slider';
9-
8+
export { default as Slider } from './Slider';
109
export { default as SliderSkeleton } from './Slider.Skeleton';
11-
export default Slider;
12-
export { Slider };

0 commit comments

Comments
 (0)