fix: type fix for onActionButtonClick in Notification component #19986 (#20262)

* fix: type fix for onActionButtonClick in Notification component #19986

* fix: type fix for onActionButtonClick in Notification component #19986

* fix: type fix for onActionButtonClick in Notification component #19986

* fix: prop type in the source components to keep a single source of truth

Author: sojinantony01

packages/react/src/components/Notification/Notification.tsx

@@ -14,6 +14,7 @@ import React, {
   useEffect,
   useRef,
   useState,
+  type ComponentProps,
 } from 'react';
 import { deprecate } from '../../prop-types/deprecate';
 import cx from 'classnames';
@@ -89,7 +90,7 @@ export interface NotificationActionButtonProps extends ButtonProps<'button'> {
   /**
    * Optionally specify a click handler for the notification action button.
    */
-  onClick?(): void;
+  onClick?: ComponentProps<typeof Button>['onClick'];
 }
 
 export function NotificationActionButton({
@@ -882,7 +883,9 @@ export interface ActionableNotificationProps
   /**
    * Provide a function that is called when the action is clicked
    */
-  onActionButtonClick?(): void;
+  onActionButtonClick?: ComponentProps<
+    typeof NotificationActionButton
+  >['onClick'];
 
   /**
    * Provide a function that is called when menu is closed.
@@ -1287,7 +1290,9 @@ export interface CalloutProps extends HTMLAttributes<HTMLDivElement> {
   /**
    * Provide a function that is called when the action is clicked
    */
-  onActionButtonClick?(): void;
+  onActionButtonClick?: ComponentProps<
+    typeof NotificationActionButton
+  >['onClick'];
 
   /**
    * Provide a description for "status" icon that can be read by screen readers

packages/react/src/components/Notification/__tests__/Notification-test.js

@@ -1,5 +1,5 @@
 /**
- * Copyright IBM Corp. 2016, 2023
+ * Copyright IBM Corp. 2016, 2025
  *
  * This source code is licensed under the Apache-2.0 license found in the
  * LICENSE file in the root directory of this source tree.
@@ -397,6 +397,9 @@ describe('Callout', () => {
     });
     await userEvent.click(closeButton);
     expect(onActionButtonClick).toHaveBeenCalledTimes(1);
+    expect(onActionButtonClick.mock.calls).toEqual([
+      [expect.objectContaining({ type: 'click' })],
+    ]);
   });
 
   it('interpolates matching className based on kind prop', () => {

packages/react/src/components/Notification/stories/ActionableNotification.stories.js

@@ -1,5 +1,5 @@
 /**
- * Copyright IBM Corp. 2016, 2023
+ * Copyright IBM Corp. 2016, 2025
  *
  * This source code is licensed under the Apache-2.0 license found in the
  * LICENSE file in the root directory of this source tree.
@@ -27,6 +27,7 @@ export default {
     statusIconDescription: 'notification',
     onClose: action('onClose'),
     onCloseButtonClick: action('onCloseButtonClick'),
+    onActionButtonClick: action('onActionButtonClick'),
   },
 };