feat(typescript): upgrade to v5 (#18577)

kennylam · guidari · web-flow · commit 494ab2ec725d · 2025-02-14T16:36:16.000Z
* feat(typescript): upgrade typescript-config-carbon to v5

* chore(utilities): upgrade utilities packages to typescript v5

* chore(packages): bump package versions

* chore(component): add gh issue to ts-ignore

* chore(yarn): dedupe

* chore(link): add props import

---------

Co-authored-by: Guilherme Datilio Ribeiro &lt;guilhermedatilio@gmail.com&gt;
diff --git a/.yarn/cache/typescript-config-carbon-npm-0.2.1-c0f39febdf-74adc73b35.zip b/.yarn/cache/typescript-config-carbon-npm-0.2.1-c0f39febdf-74adc73b35.zip
diff --git a/.yarn/cache/typescript-npm-4.9.4-51bdca3293-1f2cc85edc.zip b/.yarn/cache/typescript-npm-4.9.4-51bdca3293-1f2cc85edc.zip
diff --git a/.yarn/cache/typescript-npm-5.7.3-e71b273452-6a7e556de9.zip b/.yarn/cache/typescript-npm-5.7.3-e71b273452-6a7e556de9.zip
diff --git a/.yarn/cache/typescript-patch-2cdf849ef5-ba4a4e1758.zip b/.yarn/cache/typescript-patch-2cdf849ef5-ba4a4e1758.zip
diff --git a/.yarn/cache/typescript-patch-6da68bae26-dc58d777eb.zip b/.yarn/cache/typescript-patch-6da68bae26-dc58d777eb.zip
diff --git a/config/typescript-config-carbon/package.json b/config/typescript-config-carbon/package.json
@@ -1,7 +1,7 @@
 {
   "name": "typescript-config-carbon",
   "description": "TypeScript configuration for Carbon",
-  "version": "0.3.0",
+  "version": "0.4.0",
   "license": "Apache-2.0",
   "main": "index.js",
   "types": "index.d.ts",
@@ -27,7 +27,7 @@
     "build": "yarn clean && tsc"
   },
   "dependencies": {
-    "typescript": "^4.8.4"
+    "typescript": "^5.7.3"
   },
   "devDependencies": {
     "rimraf": "^6.0.0"
diff --git a/config/typescript-config-carbon/tsconfig.base.json b/config/typescript-config-carbon/tsconfig.base.json
@@ -11,7 +11,7 @@
     // "disableReferencedProjectLoad": true,             /* Reduce the number of projects loaded automatically by TypeScript. */
 
     /* Language and Environment */
-    "target": "es6",                                     /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */
+    "target": "es2017",                                  /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */
     "lib": ["dom", "dom.iterable", "esnext"],            /* Specify a set of bundled library declaration files that describe the target runtime environment. */
     "jsx": "react-jsx",                                  /* Specify what JSX code is generated. */
     // "experimentalDecorators": true,                   /* Enable experimental support for TC39 stage 2 draft decorators. */
diff --git a/packages/cli/package.json b/packages/cli/package.json
@@ -55,7 +55,7 @@
     "rollup": "^2.79.1",
     "sass": "^1.77.7",
     "sassdoc": "^2.7.3",
-    "typescript-config-carbon": "^0.3.0",
+    "typescript-config-carbon": "^0.4.0",
     "yargs": "^17.0.1"
   }
 }
diff --git a/packages/icon-build-helpers/package.json b/packages/icon-build-helpers/package.json
@@ -51,6 +51,6 @@
     "svg-parser": "^2.0.4",
     "svgo": "^1.1.1",
     "svgson": "^5.2.1",
-    "typescript-config-carbon": "^0.3.0"
+    "typescript-config-carbon": "^0.4.0"
   }
 }
diff --git a/packages/icon-helpers/package.json b/packages/icon-helpers/package.json
@@ -38,7 +38,7 @@
   "devDependencies": {
     "@carbon/cli": "^11.23.0",
     "rimraf": "^6.0.0",
-    "typescript-config-carbon": "^0.3.0"
+    "typescript-config-carbon": "^0.4.0"
   },
   "sideEffects": false,
   "dependencies": {
diff --git a/packages/react/package.json b/packages/react/package.json
@@ -131,7 +131,7 @@
     "storybook-addon-accessibility-checker": "^3.1.61-rc.3",
     "stream-browserify": "^3.0.0",
     "style-loader": "^4.0.0",
-    "typescript-config-carbon": "^0.3.0",
+    "typescript-config-carbon": "^0.4.0",
     "webpack": "^5.65.0",
     "webpack-dev-server": "^5.0.0"
   },
diff --git a/packages/react/src/components/DataTable/TableBody.tsx b/packages/react/src/components/DataTable/TableBody.tsx
@@ -18,7 +18,7 @@ export interface TableBodyProps extends ReactAttr<HTMLTableSectionElement> {
 
 const TableBody = ({ children, className, ...rest }: TableBodyProps) => (
   <tbody
-    aria-live={'polite' || rest['aria-live']}
+    aria-live={rest['aria-live'] ?? 'polite'}
     className={className}
     {...rest}>
     {children}
diff --git a/packages/react/src/components/InlineLoading/InlineLoading.tsx b/packages/react/src/components/InlineLoading/InlineLoading.tsx
@@ -120,7 +120,7 @@ const InlineLoading = ({
     <div
       className={loadingClasses}
       {...rest}
-      aria-live={'assertive' || rest['aria-live']}>
+      aria-live={rest['aria-live'] ?? 'assertive'}>
       {loadingAnimation}
       {description && loadingText}
     </div>
diff --git a/packages/react/src/components/MultiSelect/FilterableMultiSelect.tsx b/packages/react/src/components/MultiSelect/FilterableMultiSelect.tsx
@@ -38,10 +38,7 @@ import {
   type MultiSelectSortingProps,
   sortingPropTypes,
 } from './MultiSelectPropTypes';
-import ListBox, {
-  ListBoxMenuIconTranslationKey,
-  PropTypes as ListBoxPropTypes,
-} from '../ListBox';
+import ListBox, { PropTypes as ListBoxPropTypes } from '../ListBox';
 import { ListBoxTrigger, ListBoxSelection } from '../ListBox/next';
 import { match, keys } from '../../internal/keyboard';
 import { defaultItemToString } from './tools/itemToString';
@@ -376,6 +373,9 @@ const FilterableMultiSelect = React.forwardRef(function FilterableMultiSelect<
     clearSelection,
   } = useSelection({
     disabled,
+    // TODO: remove @ts-ignore when type is fixed,
+    // see https://github.com/carbon-design-system/carbon/issues/18575
+    // @ts-ignore
     initialSelectedItems,
     onChange,
     selectedItems: selected,
diff --git a/packages/react/src/components/MultiSelect/MultiSelect.tsx b/packages/react/src/components/MultiSelect/MultiSelect.tsx
@@ -429,10 +429,16 @@ const MultiSelect = React.forwardRef(
       clearSelection,
     } = useSelection({
       disabled,
+      // TODO: remove @ts-ignore when type is fixed,
+      // see https://github.com/carbon-design-system/carbon/issues/18575
+      // @ts-ignore
       initialSelectedItems,
       onChange,
       selectedItems: selected,
       selectAll,
+      // TODO: remove @ts-ignore when type is fixed,
+      // see https://github.com/carbon-design-system/carbon/issues/18575
+      // @ts-ignore
       filteredItems,
     });
 
diff --git a/packages/react/src/components/UIShell/HeaderMenuItem.tsx b/packages/react/src/components/UIShell/HeaderMenuItem.tsx
@@ -15,7 +15,7 @@ import React, {
   WeakValidationMap,
 } from 'react';
 import cx from 'classnames';
-import Link, { LinkPropTypes } from './Link';
+import Link, { LinkProps, LinkPropTypes } from './Link';
 import { usePrefix } from '../../internal/usePrefix';
 import deprecate from '../../prop-types/deprecate';
 import { PolymorphicComponentPropWithRef } from '../../internal/PolymorphicProps';
@@ -69,7 +69,7 @@ const HeaderMenuItem: HeaderMenuItemComponent = forwardRef(
     return (
       <li className={className} role={role}>
         <Link
-          {...rest}
+          {...(rest as LinkProps<E>)}
           aria-current={ariaCurrent}
           className={linkClassName}
           ref={ref}
diff --git a/packages/react/src/components/UIShell/HeaderName.tsx b/packages/react/src/components/UIShell/HeaderName.tsx
@@ -24,7 +24,7 @@ export default function HeaderName<E extends ElementType = 'a'>({
   const selectorPrefix = usePrefix();
   const className = cx(`${selectorPrefix}--header__name`, customClassName);
   return (
-    <Link {...rest} className={className}>
+    <Link {...(rest as LinkProps<E>)} className={className}>
       {prefix && (
         <>
           <span className={`${selectorPrefix}--header__name--prefix`}>
diff --git a/packages/react/src/components/UIShell/SideNavLink.tsx b/packages/react/src/components/UIShell/SideNavLink.tsx
@@ -104,7 +104,7 @@ const SideNavLink: SideNavLinkComponent = forwardRef(function SideNavLink<
   return (
     <SideNavItem large={large}>
       <Link
-        {...rest}
+        {...(rest as LinkProps<E>)}
         className={className}
         ref={ref}
         tabIndex={
diff --git a/packages/utilities-react/package.json b/packages/utilities-react/package.json
@@ -44,8 +44,8 @@
   "devDependencies": {
     "esbuild": "^0.25.0",
     "rimraf": "^6.0.0",
-    "typescript": "^4.8.4",
-    "typescript-config-carbon": "^0.3.0"
+    "typescript": "^5.7.3",
+    "typescript-config-carbon": "^0.4.0"
   },
   "dependencies": {
     "@carbon/utilities": "^0.4.0",
diff --git a/packages/utilities/package.json b/packages/utilities/package.json
@@ -40,8 +40,8 @@
   "devDependencies": {
     "esbuild": "^0.25.0",
     "rimraf": "^6.0.0",
-    "typescript": "^4.8.4",
-    "typescript-config-carbon": "^0.3.0"
+    "typescript": "^5.7.3",
+    "typescript-config-carbon": "^0.4.0"
   },
   "dependencies": {
     "@ibm/telemetry-js": "^1.6.1"
diff --git a/packages/web-components/package.json b/packages/web-components/package.json
@@ -118,7 +118,7 @@
     "storybook": "^8.4.7",
     "storybook-addon-accessibility-checker": "^3.1.61-rc.3",
     "temp": "^0.9.0",
-    "typescript-config-carbon": "^0.2.0",
+    "typescript-config-carbon": "^0.4.0",
     "vite": "^5.0.7",
     "web-component-analyzer": "2.0.0"
   },
diff --git a/yarn.lock b/yarn.lock
@@ -1767,7 +1767,7 @@ __metadata:
     rollup: "npm:^2.79.1"
     sass: "npm:^1.77.7"
     sassdoc: "npm:^2.7.3"
-    typescript-config-carbon: "npm:^0.3.0"
+    typescript-config-carbon: "npm:^0.4.0"
     yargs: "npm:^17.0.1"
   bin:
     carbon-cli: ./bin/carbon-cli.js
@@ -1874,7 +1874,7 @@ __metadata:
     svg-parser: "npm:^2.0.4"
     svgo: "npm:^1.1.1"
     svgson: "npm:^5.2.1"
-    typescript-config-carbon: "npm:^0.3.0"
+    typescript-config-carbon: "npm:^0.4.0"
   languageName: unknown
   linkType: soft
 
@@ -1894,7 +1894,7 @@ __metadata:
     "@carbon/cli": "npm:^11.23.0"
     "@ibm/telemetry-js": "npm:^1.5.0"
     rimraf: "npm:^6.0.0"
-    typescript-config-carbon: "npm:^0.3.0"
+    typescript-config-carbon: "npm:^0.4.0"
   languageName: unknown
   linkType: soft
 
@@ -2069,7 +2069,7 @@ __metadata:
     stream-browserify: "npm:^3.0.0"
     style-loader: "npm:^4.0.0"
     tabbable: "npm:^6.2.0"
-    typescript-config-carbon: "npm:^0.3.0"
+    typescript-config-carbon: "npm:^0.4.0"
     use-resize-observer: "npm:^6.0.0"
     webpack: "npm:^5.65.0"
     webpack-dev-server: "npm:^5.0.0"
@@ -2216,8 +2216,8 @@ __metadata:
     "@ibm/telemetry-js": "npm:^1.6.1"
     esbuild: "npm:^0.25.0"
     rimraf: "npm:^6.0.0"
-    typescript: "npm:^4.8.4"
-    typescript-config-carbon: "npm:^0.3.0"
+    typescript: "npm:^5.7.3"
+    typescript-config-carbon: "npm:^0.4.0"
   peerDependencies:
     react: ^16.8.6 || ^17.0.1 || ^18.2.0
   languageName: unknown
@@ -2230,8 +2230,8 @@ __metadata:
     "@ibm/telemetry-js": "npm:^1.6.1"
     esbuild: "npm:^0.25.0"
     rimraf: "npm:^6.0.0"
-    typescript: "npm:^4.8.4"
-    typescript-config-carbon: "npm:^0.3.0"
+    typescript: "npm:^5.7.3"
+    typescript-config-carbon: "npm:^0.4.0"
   languageName: unknown
   linkType: soft
 
@@ -2288,7 +2288,7 @@ __metadata:
     storybook-addon-accessibility-checker: "npm:^3.1.61-rc.3"
     temp: "npm:^0.9.0"
     tslib: "npm:^2.6.3"
-    typescript-config-carbon: "npm:^0.2.0"
+    typescript-config-carbon: "npm:^0.4.0"
     vite: "npm:^5.0.7"
     web-component-analyzer: "npm:2.0.0"
   languageName: unknown
@@ -26892,25 +26892,16 @@ __metadata:
   languageName: node
   linkType: hard
 
-"typescript-config-carbon@npm:^0.2.0":
-  version: 0.2.1
-  resolution: "typescript-config-carbon@npm:0.2.1"
-  dependencies:
-    typescript: "npm:^4.8.4"
-  checksum: 10/74adc73b35663defbe80734f1f44f50b9c56b5e4d837acc6507453a840edcd55728fadf9af0e60896fad0ae73dd9cec506acad1fd6cbb2c9430f9a73b9c0f683
-  languageName: node
-  linkType: hard
-
-"typescript-config-carbon@npm:^0.3.0, typescript-config-carbon@workspace:config/typescript-config-carbon":
+"typescript-config-carbon@npm:^0.4.0, typescript-config-carbon@workspace:config/typescript-config-carbon":
   version: 0.0.0-use.local
   resolution: "typescript-config-carbon@workspace:config/typescript-config-carbon"
   dependencies:
     rimraf: "npm:^6.0.0"
-    typescript: "npm:^4.8.4"
+    typescript: "npm:^5.7.3"
   languageName: unknown
   linkType: soft
 
-"typescript@npm:5.5.4, typescript@npm:>=3 < 6":
+"typescript@npm:5.5.4":
   version: 5.5.4
   resolution: "typescript@npm:5.5.4"
   bin:
@@ -26920,13 +26911,13 @@ __metadata:
   languageName: node
   linkType: hard
 
-"typescript@npm:^4.8.4":
-  version: 4.9.4
-  resolution: "typescript@npm:4.9.4"
+"typescript@npm:>=3 < 6, typescript@npm:^5.7.3":
+  version: 5.7.3
+  resolution: "typescript@npm:5.7.3"
   bin:
     tsc: bin/tsc
     tsserver: bin/tsserver
-  checksum: 10/1f2cc85edcd1e3ae978d139ff906714f509256a955669bf5b1e51f4d004e3e42cd64436175ef770ce2e6b3954412d32fd0ddc1e68147fdfff2809dc5e4c06b49
+  checksum: 10/6a7e556de91db3d34dc51cd2600e8e91f4c312acd8e52792f243c7818dfadb27bae677175fad6947f9c81efb6c57eb6b2d0c736f196a6ee2f1f7d57b74fc92fa
   languageName: node
   linkType: hard
 
@@ -26940,7 +26931,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"typescript@patch:typescript@npm%3A5.5.4#optional!builtin<compat/typescript>, typescript@patch:typescript@npm%3A>=3 < 6#optional!builtin<compat/typescript>":
+"typescript@patch:typescript@npm%3A5.5.4#optional!builtin<compat/typescript>":
   version: 5.5.4
   resolution: "typescript@patch:typescript@npm%3A5.5.4#optional!builtin<compat/typescript>::version=5.5.4&hash=379a07"
   bin:
@@ -26950,13 +26941,13 @@ __metadata:
   languageName: node
   linkType: hard
 
-"typescript@patch:typescript@npm%3A^4.8.4#optional!builtin<compat/typescript>":
-  version: 4.9.4
-  resolution: "typescript@patch:typescript@npm%3A4.9.4#optional!builtin<compat/typescript>::version=4.9.4&hash=289587"
+"typescript@patch:typescript@npm%3A>=3 < 6#optional!builtin<compat/typescript>, typescript@patch:typescript@npm%3A^5.7.3#optional!builtin<compat/typescript>":
+  version: 5.7.3
+  resolution: "typescript@patch:typescript@npm%3A5.7.3#optional!builtin<compat/typescript>::version=5.7.3&hash=5786d5"
   bin:
     tsc: bin/tsc
     tsserver: bin/tsserver
-  checksum: 10/ba4a4e17588978b841063149387dd880b8f6db8dac81ef30ae437498b07aa1eb415a79e42e03e341dc02cee58e8db21d564680285e4e86b1de8df04f0fcdbc95
+  checksum: 10/dc58d777eb4c01973f7fbf1fd808aad49a0efdf545528dab9b07d94fdcb65b8751742804c3057e9619a4627f2d9cc85547fdd49d9f4326992ad0181b49e61d81
   languageName: node
   linkType: hard
 

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@`
`55`	`55`	`"rollup": "^2.79.1",`
`56`	`56`	`"sass": "^1.77.7",`
`57`	`57`	`"sassdoc": "^2.7.3",`
`58`		`- "typescript-config-carbon": "^0.3.0",`
	`58`	`+ "typescript-config-carbon": "^0.4.0",`
`59`	`59`	`"yargs": "^17.0.1"`
`60`	`60`	`}`
`61`	`61`	`}`
Original file line number	Diff line number	Diff line change
`@@ -51,6 +51,6 @@`
`51`	`51`	`"svg-parser": "^2.0.4",`
`52`	`52`	`"svgo": "^1.1.1",`
`53`	`53`	`"svgson": "^5.2.1",`
`54`		`- "typescript-config-carbon": "^0.3.0"`
	`54`	`+ "typescript-config-carbon": "^0.4.0"`
`55`	`55`	`}`
`56`	`56`	`}`