fix(OverflowMenu): ensure onClose is only called once (#20486)

* fix(OverflowMenu): ensure onClose is only called once

* test: add test

* chore: remove test story

Author: heloiselui

packages/react/src/components/OverflowMenu/OverflowMenu-test.js

@@ -117,6 +117,25 @@ describe('OverflowMenu', () => {
       expect(onClose).toHaveBeenCalled();
     });
 
+    it('should call onClose only once when menu is closed', async () => {
+      const onClose = jest.fn();
+      render(
+        <OverflowMenu
+          aria-label="Overflow menu"
+          className="extra-class"
+          onClose={onClose}>
+          <OverflowMenuItem className="test-child" itemText="one" />
+          <OverflowMenuItem className="test-child" itemText="two" />
+        </OverflowMenu>
+      );
+
+      await userEvent.click(screen.getByRole('button'));
+      await userEvent.click(screen.getByText('one'));
+      await waitFor(() => {
+        expect(onClose).toHaveBeenCalledTimes(1);
+      });
+    });
+
     it('should call onFocus', async () => {
       const onFocus = jest.fn();
       render(

packages/react/src/components/OverflowMenu/OverflowMenu.tsx

@@ -342,17 +342,13 @@ export const OverflowMenu = forwardRef<HTMLButtonElement, OverflowMenuProps>(
       }
     }, []);
 
-    const closeMenu = useCallback(
-      (onCloseMenu?: () => void) => {
-        setOpen(false);
-        // Optional callback to be executed after the state as been set to close
-        if (onCloseMenu) {
-          onCloseMenu();
-        }
-        onClose();
-      },
-      [onClose]
-    );
+    const closeMenu = useCallback((onCloseMenu?: () => void) => {
+      setOpen(false);
+      // Optional callback to be executed after the state as been set to close
+      if (onCloseMenu) {
+        onCloseMenu();
+      }
+    }, []);
 
     const closeMenuAndFocus = useCallback(() => {
       const wasClicked = click;