fix(typescript): fixing DataTable sortRow type (#18073)

#18063

Co-authored-by: Heloise Lui <71858203+heloiselui@users.noreply.github.com>
Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com>

Author: 3 people

.all-contributorsrc

@@ -1791,6 +1791,15 @@
         "code"
       ]
     },
+    {
+      "login": "gdelory",
+      "name": "Guillaume Delory",
+      "avatar_url": "https://avatars.githubusercontent.com/u/9974707?v=4",
+      "profile": "https://github.com/gdelory",
+      "contributions": [
+        "code"
+      ]
+    },
     {
       "login": "Bhas-kar",
       "name": "Kanchi Bhaskar",

README.md

@@ -328,6 +328,7 @@ check out our [Contributing Guide](/.github/CONTRIBUTING.md) and our
     <td align="center"><a href="https://github.com/heloiselui"><img src="https://avatars.githubusercontent.com/u/71858203?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Heloise Lui</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=heloiselui" title="Code">💻</a> <a href="https://github.com/carbon-design-system/carbon/commits?author=heloiselui" title="Documentation">📖</a> <a href="#a11y-heloiselui" title="Accessibility">️️️️♿️</a> <a href="https://github.com/carbon-design-system/carbon/pulls?q=is%3Apr+reviewed-by%3Aheloiselui" title="Reviewed Pull Requests">👀</a></td>
     <td align="center"><a href="https://github.com/Tweakified"><img src="https://avatars.githubusercontent.com/u/58192912?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Daniel Smith</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=Tweakified" title="Code">💻</a> <a href="#a11y-Tweakified" title="Accessibility">️️️️♿️</a> <a href="https://github.com/carbon-design-system/carbon/commits?author=Tweakified" title="Documentation">📖</a></td>
     <td align="center"><a href="https://github.com/enricobguedes"><img src="https://avatars.githubusercontent.com/u/45374536?v=4?s=100" width="100px;" alt=""/><br /><sub><b>enricobguedes</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=enricobguedes" title="Code">💻</a></td>
+    <td align="center"><a href="https://github.com/gdelory"><img src="https://avatars.githubusercontent.com/u/9974707?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Guillaume Delory</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=gdelory" title="Code">💻</a></td>
     <td align="center"><a href="https://github.com/Bhas-kar"><img src="https://avatars.githubusercontent.com/u/183294521?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Kanchi Bhaskar</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=Bhas-kar" title="Code">💻</a> <a href="https://github.com/carbon-design-system/carbon/commits?author=Bhas-kar" title="Documentation">📖</a></td>
   </tr>
 </table>

packages/react/src/components/DataTable/DataTable.tsx

@@ -245,12 +245,18 @@ export interface DataTableProps<RowType, ColTypes extends any[]>
   rows: Array<Omit<DataTableRow<ColTypes>, 'cells'>>;
   size?: DataTableSize;
   sortRow?: (
-    cellA: DataTableCell<any>,
-    cellB: DataTableCell<any>,
+    cellA: any,
+    cellB: any,
     sortRowOptions: {
       sortDirection: DataTableSortState;
       sortStates: Record<DataTableSortState, DataTableSortState>;
       locale: string;
+      key: string;
+      compare: (
+        a: number | string,
+        b: number | string,
+        locale?: string
+      ) => number;
     }
   ) => number;
   stickyHeader?: boolean;