Skip to content

Commit f836396

Browse files
adamalstonadamalston
authored
refactor: delete remnants of MultiSelect.Filterable (#18902)
1 parent 466f7d9 commit f836396

File tree

5 files changed

+9
-274
lines changed

5 files changed

+9
-274
lines changed

‎packages/react/__tests__/PublicAPI-test.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/**
2-
* Copyright IBM Corp. 2016, 2023
2+
* Copyright IBM Corp. 2016, 2025
33
*
44
* This source code is licensed under the Apache-2.0 license found in the
55
* LICENSE file in the root directory of this source tree.
@@ -180,7 +180,7 @@ test('Public API should only change with a semver change', () => {
180180
}
181181

182182
// Handle components defined as fields on a component, for example
183-
// `MultiSelect.Filterable`
183+
// `ContainedList.ContainedListItem`.
184184
if (
185185
typeof Component[key] === 'function' &&
186186
key !== 'render' &&

‎packages/react/__tests__/__snapshots__/PublicAPI-test.js.snap‎

Lines changed: 0 additions & 256 deletions
Original file line numberDiff line numberDiff line change
@@ -5301,262 +5301,6 @@ Map {
53015301
},
53025302
"MultiSelect" => Object {
53035303
"$$typeof": Symbol(react.forward_ref),
5304-
"Filterable": Object {
5305-
"$$typeof": Symbol(react.forward_ref),
5306-
"propTypes": Object {
5307-
"aria-label": [Function],
5308-
"ariaLabel": [Function],
5309-
"autoAlign": Object {
5310-
"type": "bool",
5311-
},
5312-
"clearSelectionDescription": Object {
5313-
"type": "string",
5314-
},
5315-
"clearSelectionText": Object {
5316-
"type": "string",
5317-
},
5318-
"compareItems": Object {
5319-
"type": "func",
5320-
},
5321-
"decorator": Object {
5322-
"type": "node",
5323-
},
5324-
"direction": Object {
5325-
"args": Array [
5326-
Array [
5327-
"top",
5328-
"bottom",
5329-
],
5330-
],
5331-
"type": "oneOf",
5332-
},
5333-
"disabled": Object {
5334-
"type": "bool",
5335-
},
5336-
"downshiftProps": Object {
5337-
"args": Array [
5338-
Object {
5339-
"children": Object {
5340-
"type": "func",
5341-
},
5342-
"defaultHighlightedIndex": Object {
5343-
"type": "number",
5344-
},
5345-
"defaultIsOpen": Object {
5346-
"type": "bool",
5347-
},
5348-
"environment": Object {
5349-
"args": Array [
5350-
Object {
5351-
"Node": Object {
5352-
"isRequired": true,
5353-
"type": "func",
5354-
},
5355-
"addEventListener": Object {
5356-
"isRequired": true,
5357-
"type": "func",
5358-
},
5359-
"document": Object {
5360-
"args": Array [
5361-
Object {
5362-
"activeElement": Object {
5363-
"isRequired": true,
5364-
"type": "any",
5365-
},
5366-
"body": Object {
5367-
"isRequired": true,
5368-
"type": "any",
5369-
},
5370-
"createElement": Object {
5371-
"isRequired": true,
5372-
"type": "func",
5373-
},
5374-
"getElementById": Object {
5375-
"isRequired": true,
5376-
"type": "func",
5377-
},
5378-
},
5379-
],
5380-
"isRequired": true,
5381-
"type": "shape",
5382-
},
5383-
"removeEventListener": Object {
5384-
"isRequired": true,
5385-
"type": "func",
5386-
},
5387-
},
5388-
],
5389-
"type": "shape",
5390-
},
5391-
"getA11yStatusMessage": Object {
5392-
"type": "func",
5393-
},
5394-
"getItemId": Object {
5395-
"type": "func",
5396-
},
5397-
"highlightedIndex": Object {
5398-
"type": "number",
5399-
},
5400-
"id": Object {
5401-
"type": "string",
5402-
},
5403-
"initialHighlightedIndex": Object {
5404-
"type": "number",
5405-
},
5406-
"initialInputValue": Object {
5407-
"type": "string",
5408-
},
5409-
"initialIsOpen": Object {
5410-
"type": "bool",
5411-
},
5412-
"initialSelectedItem": Object {
5413-
"type": "any",
5414-
},
5415-
"inputId": Object {
5416-
"type": "string",
5417-
},
5418-
"inputValue": Object {
5419-
"type": "string",
5420-
},
5421-
"isOpen": Object {
5422-
"type": "bool",
5423-
},
5424-
"itemCount": Object {
5425-
"type": "number",
5426-
},
5427-
"itemToString": Object {
5428-
"type": "func",
5429-
},
5430-
"labelId": Object {
5431-
"type": "string",
5432-
},
5433-
"menuId": Object {
5434-
"type": "string",
5435-
},
5436-
"onChange": Object {
5437-
"type": "func",
5438-
},
5439-
"onInputValueChange": Object {
5440-
"type": "func",
5441-
},
5442-
"onOuterClick": Object {
5443-
"type": "func",
5444-
},
5445-
"onSelect": Object {
5446-
"type": "func",
5447-
},
5448-
"onStateChange": Object {
5449-
"type": "func",
5450-
},
5451-
"onUserAction": Object {
5452-
"type": "func",
5453-
},
5454-
"scrollIntoView": Object {
5455-
"type": "func",
5456-
},
5457-
"selectedItem": Object {
5458-
"type": "any",
5459-
},
5460-
"selectedItemChanged": Object {
5461-
"type": "func",
5462-
},
5463-
"stateReducer": Object {
5464-
"type": "func",
5465-
},
5466-
"suppressRefError": Object {
5467-
"type": "bool",
5468-
},
5469-
},
5470-
],
5471-
"type": "shape",
5472-
},
5473-
"hideLabel": Object {
5474-
"type": "bool",
5475-
},
5476-
"id": Object {
5477-
"isRequired": true,
5478-
"type": "string",
5479-
},
5480-
"initialSelectedItems": Object {
5481-
"type": "array",
5482-
},
5483-
"invalid": Object {
5484-
"type": "bool",
5485-
},
5486-
"invalidText": Object {
5487-
"type": "node",
5488-
},
5489-
"itemToElement": Object {
5490-
"type": "func",
5491-
},
5492-
"itemToString": Object {
5493-
"type": "func",
5494-
},
5495-
"items": Object {
5496-
"isRequired": true,
5497-
"type": "array",
5498-
},
5499-
"light": [Function],
5500-
"locale": Object {
5501-
"type": "string",
5502-
},
5503-
"onChange": Object {
5504-
"type": "func",
5505-
},
5506-
"onInputValueChange": Object {
5507-
"type": "func",
5508-
},
5509-
"onMenuChange": Object {
5510-
"type": "func",
5511-
},
5512-
"open": Object {
5513-
"type": "bool",
5514-
},
5515-
"placeholder": Object {
5516-
"type": "string",
5517-
},
5518-
"selectionFeedback": Object {
5519-
"args": Array [
5520-
Array [
5521-
"top",
5522-
"fixed",
5523-
"top-after-reopen",
5524-
],
5525-
],
5526-
"type": "oneOf",
5527-
},
5528-
"size": Object {
5529-
"args": Array [
5530-
Array [
5531-
"sm",
5532-
"md",
5533-
"lg",
5534-
],
5535-
],
5536-
"type": "oneOf",
5537-
},
5538-
"slug": [Function],
5539-
"sortItems": Object {
5540-
"type": "func",
5541-
},
5542-
"titleText": Object {
5543-
"type": "node",
5544-
},
5545-
"translateWithId": Object {
5546-
"type": "func",
5547-
},
5548-
"useTitleInItem": Object {
5549-
"type": "bool",
5550-
},
5551-
"warn": Object {
5552-
"type": "bool",
5553-
},
5554-
"warnText": Object {
5555-
"type": "node",
5556-
},
5557-
},
5558-
"render": [Function],
5559-
},
55605304
"propTypes": Object {
55615305
"autoAlign": Object {
55625306
"type": "bool",

‎packages/react/src/components/MultiSelect/MultiSelect.mdx‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { ArgTypes, Canvas, Story, Meta } from '@storybook/blocks';
22

33
import * as MultiSelect from './MultiSelect.stories';
4+
import { Filterable } from './MultiSelect.stories';
45
import { stackblitzPrefillConfig } from '../../../previewer/codePreviewer';
56

67
<Meta isTemplate />
@@ -89,15 +90,14 @@ const options = [
8990
### Filtering
9091

9192
The `FilterableMultiSelect` component allows for filtering the list of
92-
selectable items to a subset. The `FilterableMultiSelect` component allows for
93-
filtering the list of selectable items to a subset.
93+
selectable items to a subset.
9494

9595
<Canvas
96-
of={MultiSelect.Filterable}
96+
of={Filterable}
9797
additionalActions={[
9898
{
9999
title: 'Open in Stackblitz',
100-
onClick: () => stackblitzPrefillConfig(MultiSelect.Filterable),
100+
onClick: () => stackblitzPrefillConfig(Filterable),
101101
},
102102
]}
103103
/>

‎packages/react/src/components/MultiSelect/MultiSelect.stories.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -354,7 +354,7 @@ export const Filterable = (args) => {
354354
}}>
355355
<FilterableMultiSelect
356356
id="carbon-multiselect-example-3"
357-
titleText="Multiselect title"
357+
titleText="FilterableMultiSelect title"
358358
helperText="This is helper text"
359359
items={items}
360360
itemToString={(item) => (item ? item.text : '')}

‎packages/react/src/components/MultiSelect/index.tsx‎

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,14 @@
11
/**
2-
* Copyright IBM Corp. 2016, 2023
2+
* Copyright IBM Corp. 2016, 2025
33
*
44
* This source code is licensed under the Apache-2.0 license found in the
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8-
import { deprecateFieldOnObject } from '../../internal/deprecateFieldOnObject';
9-
108
import MultiSelect from './MultiSelect';
119
import { default as FilterableMultiSelect } from './FilterableMultiSelect';
1210

13-
FilterableMultiSelect.displayName = 'MultiSelect.Filterable';
14-
// @ts-expect-error: The attribute indeed does not exist on the object,
15-
// but since it is already deprecated, we do not have to fix it.
16-
MultiSelect.Filterable = FilterableMultiSelect;
17-
18-
if (__DEV__) {
19-
deprecateFieldOnObject(MultiSelect, 'Filterable', FilterableMultiSelect);
20-
}
11+
FilterableMultiSelect.displayName = 'FilterableMultiSelect';
2112

2213
export { FilterableMultiSelect, MultiSelect };
2314
export default MultiSelect;

0 commit comments

Comments
 (0)