Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(grid): update elements example, grid pkg readme #9339

Merged

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Jul 27, 2021

Closes #8556

Adds new "Experimental CSS Grid usage" section to the @carbon/grid readme. Also updates the css-grid elements example and adds it into the root nav.

Changelog

New

  • grid: experimental css grid usage readme docs

Changed

  • css-grid elements example updated with correct examples

Removed

  • the unneeded css-grid layouts page which caused issues building the other elements example pages

Testing / Reviewing

The elements preview should show the "css-grid" link in the main page. The css-grid example should show examples that look like the storybook, example screenshot.

@netlify
Copy link

netlify bot commented Jul 27, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 37e891b

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61032a4e5f49ea000832afc1

😎 Browse the preview: https://deploy-preview-9339--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jul 27, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 37e891b

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61032a4ed2fb0b00073e04b2

😎 Browse the preview: https://deploy-preview-9339--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 27, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 8db778c

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61006a317bad740007bcc0df

😎 Browse the preview: https://deploy-preview-9339--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Jul 27, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 37e891b

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61032a4e0685520007fda526

😎 Browse the preview: https://deploy-preview-9339--carbon-components-react.netlify.app

Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 yay!!

@kodiakhq kodiakhq bot merged commit 4f11064 into carbon-design-system:main Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docs for CSS Grid Usage
4 participants