refactor: remove fatal error from the constructor of texture. #22
Conversation
| public init(size:Size) { | ||
| self.size = size | ||
| internalTexture = Texture(device:sharedMetalRenderingDevice.device, orientation:.portrait, width:Int(size.width), height:Int(size.height), timingStyle:.stillImage) | ||
| internalTexture = Texture(device:sharedMetalRenderingDevice.device, orientation:.portrait, width:Int(size.width), height:Int(size.height), timingStyle:.stillImage)! |
There was a problem hiding this comment.
question: Is it safe to use force unwrap here?
ChiaoteNi
changed the base branch from
master
to
feat/faceMask-for-kirakira-effect
|
I vote option 2 |
Sorry please ignore it |
|
Hi @yyjim, I've updated the code with the option 1, please help to review the PR again when you're available, thanks! |
| else { | ||
| assertionFailure("CommandBuffer or Texture creation failed") | ||
| removeTransientInputs() | ||
| textureInputSemaphore.signal() |
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes we should, and I notice it shouldn't be invoke inside the defer
Let we add and remove them in the next commit, thanks!
There was a problem hiding this comment.
I'm not really sure if this correct or not. The L138 call also wait.
There was a problem hiding this comment.
Calling it in defer seems reasonable to me since it calls wait at the beginning.
it only wants to run one at the time.
There was a problem hiding this comment.
That's weird...sorry I didn't notice this 🤔
I'll go back to check this later after I update the implementation for the PR of the face mask.
- Stop the process when it occurs in the newTextureAvailable - Force unwrap the value for those who won't be used in PicCollage
ChiaoteNi
force-pushed
the
refactor/remove-fetalError-from-the-constructor-of-Texture
branch
from
646d38d to
870abf3
Compare
ChiaoteNi
changed the base branch from
feat/faceMask-for-kirakira-effect
to
master
3 participants
Descriptions:
Solution:
Topics for discussion:
In CBVisualEffectBuiltIn, we use the input as the output directly when the makeTexture function return nil: