Skip to content

Conversation

@crqrdotcom
Copy link
Contributor

@crqrdotcom crqrdotcom commented Oct 12, 2021

Partially fixes #7

  • Add global option --project (aliased -p) to specify the project we want to work with in a monorepo
  • Adds support to work seamlessly with previous tags that were prefixed with v
  • Support managing multiple tags with multiple versions in a monorepo

NEXT:

  • Only consider version updates from commits done inside the directory specified by --project
  • Make the default value for --project the user's working directory

Will create separate issues for these as they're non-blocking for the feature in review

@crqrdotcom crqrdotcom self-assigned this Oct 12, 2021
@crqrdotcom crqrdotcom added the enhancement New feature or request label Oct 12, 2021
@crqrdotcom crqrdotcom changed the title feat: support monorepos [WIP] feat: support monorepos Oct 12, 2021
@crqrdotcom crqrdotcom changed the title [WIP] feat: support monorepos feat: support monorepos Oct 12, 2021
@crqrdotcom crqrdotcom marked this pull request as ready for review October 12, 2021 12:38
@crqrdotcom crqrdotcom enabled auto-merge (squash) October 12, 2021 12:40
Copy link

@jsmvaldivia jsmvaldivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like whenever you are calling a piece of code that returns a value and an err, you could wrap it up in an unexported func. You might end with several seemingly useless functions but when maintaining, one typically reads the exported ones first and try to figure out at a higher level what do they do exactly. IMO having all the error handling within the exported function code reduces that readability

@crqrdotcom
Copy link
Contributor Author

I feel like whenever you are calling a piece of code that returns a value and an err, you could wrap it up in an unexported func. You might end with several seemingly useless functions but when maintaining, one typically reads the exported ones first and try to figure out at a higher level what do they do exactly. IMO having all the error handling within the exported function code reduces that readability

I agree with your comment and after changing accordingly can see the benefits already. Thanks!

@jsmvaldivia jsmvaldivia self-requested a review October 12, 2021 15:53
@crqrdotcom crqrdotcom merged commit ab5fe6c into main Oct 12, 2021
@crqrdotcom crqrdotcom deleted the feat/support-monorepos branch October 12, 2021 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support monorepos with multiple projects

3 participants