-
Notifications
You must be signed in to change notification settings - Fork 1
feat: support monorepos #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jsmvaldivia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like whenever you are calling a piece of code that returns a value and an err, you could wrap it up in an unexported func. You might end with several seemingly useless functions but when maintaining, one typically reads the exported ones first and try to figure out at a higher level what do they do exactly. IMO having all the error handling within the exported function code reduces that readability
I agree with your comment and after changing accordingly can see the benefits already. Thanks! |
Partially fixes #7
--project(aliased-p) to specify the project we want to work with in a monorepovNEXT:
--project--projectthe user's working directoryWill create separate issues for these as they're non-blocking for the feature in review