Skip to content

Conversation

@carson-katri
Copy link
Owner

@carson-katri carson-katri commented Jun 23, 2020

Adds a Timeout RequestParam, as well as a new unit test to cover the timeout.

Timeout(60)
Timeout(60, for: .request)
Timeout(60, for: .resource)

@carson-katri carson-katri linked an issue Jun 23, 2020 that may be closed by this pull request
@carson-katri carson-katri added this to the v1.3.0 milestone Jun 23, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2020

Codecov Report

Merging #27 into master will increase coverage by 0.14%.
The diff coverage is 91.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
+ Coverage   86.03%   86.17%   +0.14%     
==========================================
  Files          21       22       +1     
  Lines         716      745      +29     
==========================================
+ Hits          616      642      +26     
- Misses        100      103       +3     
Impacted Files Coverage Δ
Sources/Request/Request/RequestParams/Body.swift 100.00% <ø> (ø)
Sources/Request/Request/RequestParams/Method.swift 100.00% <ø> (ø)
...ces/Request/Request/RequestParams/QueryParam.swift 100.00% <ø> (ø)
...s/Request/Request/RequestParams/RequestParam.swift 60.00% <33.33%> (-40.00%) ⬇️
Sources/Request/Request/Request.swift 93.04% <91.66%> (-0.23%) ⬇️
Sources/Request/Request/RequestParams/Header.swift 100.00% <100.00%> (ø)
...ources/Request/Request/RequestParams/Timeout.swift 100.00% <100.00%> (ø)
Tests/RequestTests/RequestTests.swift 93.56% <100.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 678327f...c667934. Read the comment docs.

@carson-katri carson-katri merged commit 6749d75 into master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to set the timeout

3 participants