removed dbSpecified parameter for NewAdapter #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks. I also once tried to find a way to determine dbname existence without parsing the string manually but failed. This solution clearly looks better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://docs.mongodb.com/manual/reference/connection-string/ doc, database name can be specified in the connection string itself. Using
mgo, it can be easily verified if database name is specifiedor not. I believe this was the whole and the only point of having
dbSpecifiedoptional argument inNewAdapterfunction. Using the above specification andmgo.ParseURL()function i have removed this while pertaining the behavior.