Skip to content

Conversation

@Hellobigxu
Copy link

@Hellobigxu Hellobigxu commented Apr 21, 2018

Fixed #6. When do RemoveFilteredPolicy(0,"sub","","act") doesn't affect the policy in the storage
Adds unit test cases to cover new functionality.

Hellobigxu and others added 3 commits April 20, 2018 12:15
ignore “” string, just keep same logic with casbin
@coveralls
Copy link

coveralls commented Apr 21, 2018

Coverage Status

Coverage increased (+10.0%) to 85.946% when pulling 1c65afd on Hellobigxu:adapter-filternull into 5226322 on casbin:master.

@hsluoyz
Copy link
Member

hsluoyz commented Apr 21, 2018

Hi,

  1. Please do not use commit messages like Update adapter.go, just say what the commit does (see other commits). These commits are need to be reworked.
  2. Please do not let the code coverage decrease.

guoxing.xu and others added 4 commits April 21, 2018 16:06
Fixed a bug. When do RemoveFilteredPolicy(0,sub,,act) doesn't affect the policy in the storage
@Hellobigxu Hellobigxu closed this Apr 21, 2018
@Hellobigxu Hellobigxu deleted the adapter-filternull branch April 21, 2018 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants