Bug Python3 : Can't iterate on a dict in all_roles.keys

[Obimka]

File : rbac/default_role_manager/role_manager.py
Line : 15~16

 def has_role(self, name):
        return name in self.all_roles.keys()

Error : In python3 you can't iterate on a dict

Fix :

-        return name in self.all_roles.keys()
+        return name in list(self.all_roles.keys())

[Obimka]

Seems that the same problem appears in other functions

[leeqvip]

I am not sure if there is such a problem, after all, our test cases are not comprehensive.
But still passed the test.

Look at the code below:

print("Age" in dict({'Name': 'Runoob', 'Age': 7}).keys())

It will output True in Python3.6

[hsluoyz]

@Obimka this project is recently developed and totally based on Python 3. Can you provide a simple but self-contained example to show your error?

[Obimka]

Here is a part of logs from my project:

2019-02-12T15:38:46.305528204+01:00 2019-02-12 15:38:46,303 - ERROR - ApplicationError: ApplicationError(error=<zephir.error.exception>, args=[], kwargs={'reason': "unhashable type: 'dict'"}, enc_algo=None): Traceback (most recent call last):
2019-02-12T15:38:46.305585251+01:00   File "/usr/lib/python3/dist-packages/zephir/wamp/register.py", line 105, in wrapper
2019-02-12T15:38:46.305626182+01:00     _profil = getattr(self, profil_adapter)(cursor, uri, parsed_arguments)
2019-02-12T15:38:46.305656003+01:00   File "/srv/bin/controller", line 51, in get_profil_for_server
2019-02-12T15:38:46.305700909+01:00     if self.policy.enforce(profil, uri, 'access'):
2019-02-12T15:38:46.305738848+01:00   File "/usr/local/lib/python3.6/dist-packages/casbin/enforcer.py", line 240, in enforce
2019-02-12T15:38:46.305768301+01:00     result = expression.evaluate(exp_string, parameters, functions)
2019-02-12T15:38:46.305914739+01:00   File "/usr/local/lib/python3.6/dist-packages/casbin/util/expression.py", line 7, in evaluate
2019-02-12T15:38:46.305997958+01:00     return simple_eval(exp_string, functions=functions, names=parameters)
2019-02-12T15:38:46.306030041+01:00   File "/usr/local/lib/python3.6/dist-packages/simpleeval.py", line 579, in simple_eval
2019-02-12T15:38:46.306094826+01:00     return s.eval(expr)
2019-02-12T15:38:46.306125418+01:00   File "/usr/local/lib/python3.6/dist-packages/simpleeval.py", line 309, in eval
2019-02-12T15:38:46.306154054+01:00     return self._eval(ast.parse(expr.strip()).body[0].value)
2019-02-12T15:38:46.306182346+01:00   File "/usr/local/lib/python3.6/dist-packages/simpleeval.py", line 320, in _eval
2019-02-12T15:38:46.306210095+01:00     return handler(node)
2019-02-12T15:38:46.306237982+01:00   File "/usr/local/lib/python3.6/dist-packages/simpleeval.py", line 355, in _eval_boolop
2019-02-12T15:38:46.306266583+01:00     vout = self._eval(value)
2019-02-12T15:38:46.306295708+01:00   File "/usr/local/lib/python3.6/dist-packages/simpleeval.py", line 320, in _eval
2019-02-12T15:38:46.306323711+01:00     return handler(node)
2019-02-12T15:38:46.306390334+01:00   File "/usr/local/lib/python3.6/dist-packages/simpleeval.py", line 349, in _eval_boolop
2019-02-12T15:38:46.306419634+01:00     vout = self._eval(value)
2019-02-12T15:38:46.306447667+01:00   File "/usr/local/lib/python3.6/dist-packages/simpleeval.py", line 320, in _eval
2019-02-12T15:38:46.306475798+01:00     return handler(node)
2019-02-12T15:38:46.306568641+01:00   File "/usr/local/lib/python3.6/dist-packages/simpleeval.py", line 388, in _eval_call
2019-02-12T15:38:46.30659986+01:00     **dict(self._eval(k) for k in node.keywords)
2019-02-12T15:38:46.306627779+01:00   File "/usr/local/lib/python3.6/dist-packages/casbin/util/builtin_operators.py", line 126, in f
2019-02-12T15:38:46.306700598+01:00     return rm.has_link(name1, name2)
2019-02-12T15:38:46.30672871+01:00   File "/usr/local/lib/python3.6/dist-packages/casbin/rbac/default_role_manager/role_manager.py", line 62, in has_link
2019-02-12T15:38:46.306772833+01:00     if not self.has_role(name1) or not self.has_role(name2):
2019-02-12T15:38:46.306813292+01:00   File "/usr/local/lib/python3.6/dist-packages/casbin/rbac/default_role_manager/role_manager.py", line 16, in has_role
2019-02-12T15:38:46.306841947+01:00     return name in self.all_roles.keys()
2019-02-12T15:38:46.306869648+01:00 TypeError: unhashable type: 'dict'

self.all_roles.keys() seems to return a dict that you can't iterate in python3 with a simple "in".
There is not much more to show. I only tried to test the enforcer.
In this case,the arguments passed to the enforcer :

   profil = 'admin'
   uri = 'v1.server.list'
   action = 'allowed'

Policy applied :

p, user, v1.server.list, allowed
g, admin, user

Model :

[request_definition]
r = sub, obj, act

[policy_definition]
p = sub, obj, act

[role_definition]
g = _, _

[policy_effect]
e = some(where (p.eft == allow))

[matchers]
m = g(r.sub, p.sub) && r.obj == p.obj && r.act == p.act || r.sub == "root"

[techqiang]

You can open the log by passing the third parameter through the Enforcer.

rbac_model.conf:

[request_definition]
r = sub, obj, act

[policy_definition]
p = sub, obj, act

[role_definition]
g = _, _

[policy_effect]
e = some(where (p.eft == allow))

[matchers]
m = g(r.sub, p.sub) && r.obj == p.obj && r.act == p.act || r.sub == "root"

rbac_policy.csv:

p, user, v1.server.list, allowed
g, admin, user

code bellow:

import casbin

e = casbin.Enforcer("examples/rbac_model.conf", "examples/rbac_policy.csv", True)

sub = "admin"  # the user that wants to access a resource.
obj = "v1.server.list"  # the resource that is going to be accessed.
act = "allowed"  # the operation that the user performs on the resource.

if e.enforce(sub, obj, act):
    # permit alice to read data1
    pass
else:
    # deny the request, show an error
    pass

then run the code:

# python3 test.py 
2019-02-14 16:42:43,883 - INFO - Model:
2019-02-14 16:42:43,883 - INFO - r.r: sub, obj, act
2019-02-14 16:42:43,883 - INFO - p.p: sub, obj, act
2019-02-14 16:42:43,883 - INFO - e.e: some(where (p_eft == allow))
2019-02-14 16:42:43,883 - INFO - m.m: g(r_sub, p_sub) && r_obj == p_obj && r_act == p_act || r_sub == "root"
2019-02-14 16:42:43,883 - INFO - g.g: _, _
2019-02-14 16:42:43,886 - INFO - Policy:
2019-02-14 16:42:43,886 - INFO - p: sub, obj, act: [['user', 'v1.server.list', 'allowed']]
2019-02-14 16:42:43,886 - INFO - g: _, _: [['admin', 'user']]
2019-02-14 16:42:43,886 - INFO - Role links for: g
2019-02-14 16:42:43,886 - INFO - admin < user
2019-02-14 16:42:43,887 - INFO - Request: admin, v1.server.list, allowed ---> True

[Obimka]

I'll give it another try as soon as possible and report with some more informations.