Skip to content

Update minishift to 1.5.0#38073

Merged
commitay merged 1 commit into
Homebrew:masterfrom
brgnepal:minishift-1.5.0
Aug 29, 2017
Merged

Update minishift to 1.5.0#38073
commitay merged 1 commit into
Homebrew:masterfrom
brgnepal:minishift-1.5.0

Conversation

@brgnepal
Copy link
Copy Markdown

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Additionally, if updating a cask:

  • sha256 changed but version stayed the same ([what is this?][version-checksum]).
    I’m providing public confirmation below.

My testing:

# Edit cask file
$ vim minishift.rb

# Install new cask
$ brew cask install minishift.rb
==> Satisfying dependencies
==> Downloading https://github.com/minishift/minishift/releases/download/v1.5.0/minishift-1.5.0-darwin-amd64.tgz
######################################################################## 100.0%
==> Verifying checksum for Cask minishift
==> Installing Cask minishift
==> Linking Binary 'minishift' to '/usr/local/bin/minishift'.
🍺  minishift was successfully installed!

# Check version
$ /usr/local/bin/minishift version
minishift v1.5.0+ae62cf2

# Audit Check
$ brew cask audit minishift.rb --download
==> Downloading https://github.com/minishift/minishift/releases/download/v1.5.0/minishift-1.5.0-darwin-amd64.tgz
Already downloaded: /Users/devtools/Library/Caches/Homebrew/Cask/minishift--1.5.0.tgz
==> Verifying checksum for Cask minishift
audit for minishift: passed

# Style Check
$ brew cask style minishift.rb

1 file inspected, no offenses detected

@commitay commitay merged commit c90e795 into Homebrew:master Aug 29, 2017
@commitay
Copy link
Copy Markdown
Contributor

Thanks for the PR!

@brgnepal brgnepal deleted the minishift-1.5.0 branch January 4, 2018 09:06
@Homebrew Homebrew locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants