Skip to content

improvements #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 26, 2020
Merged

improvements #62

merged 6 commits into from
Mar 26, 2020

Conversation

@bartes
Copy link
Contributor

@bartes bartes commented Mar 24, 2020 •
edited
Loading

  • added config validation before sending api request
  • move some files to apis namespace (response, request, session)
  • updated ci config

@bartes bartes self-assigned this Mar 24, 2020
@bartes bartes marked this pull request as ready for review March 26, 2020 10:59
@bartes bartes changed the title added config validation and move files to apis namespace improvements Mar 26, 2020
@bartes bartes changed the base branch from improve_ip_headers to master March 26, 2020 11:15
@bartes bartes force-pushed the add_validation_and_move_files branch from c473d86 to d00613d Compare March 26, 2020 11:20
@bartes bartes force-pushed the add_validation_and_move_files branch from 92a7539 to 1943628 Compare March 26, 2020 11:34
@bartes bartes requested a review from dawlib March 26, 2020 11:34
@bartes bartes merged commit 9a5b912 into master Mar 26, 2020
@bartes bartes deleted the add_validation_and_move_files branch March 26, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dawlib dawlib dawlib approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bartes bartes

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bartes @dawlib