Removed call to users array#10
Closed
GeekTrainer wants to merge 3 commits intoCatalystCode:masterfrom
GeekTrainer:master
Closed
Removed call to users array#10GeekTrainer wants to merge 3 commits intoCatalystCode:masterfrom GeekTrainer:master
GeekTrainer wants to merge 3 commits intoCatalystCode:masterfrom
GeekTrainer:master
Conversation
Author
|
Made updates to how the resurrect code works. Rather than parsing items out, I simply serialize the address and pass that around as needed. |
bnookala
reviewed
Oct 14, 2016
| "botbuilder": "^3.2.3", | ||
| "passport": "^0.3.2", | ||
| "passport-azure-ad": "2.0.0", | ||
| "querystring": "^0.2.0", |
Member
There was a problem hiding this comment.
kind of confused; are you using the builtin querystring module in your code? (https://nodejs.org/api/querystring.html)
Author
There was a problem hiding this comment.
I don't know why I did that. :-) That can be removed.
ritazh
reviewed
Oct 24, 2016
| useAuth: true }; | ||
|
|
||
| var continueMsg = new builder.Message().address(address).text("signin?authcode=" + authcode + "&code=" + code + "&name=" + req.user.displayName + "&email=" + req.user.email); | ||
| bot.receive(continueMsg.toMessage()); |
Collaborator
There was a problem hiding this comment.
In this PR, continueMsg is not set.
ritazh
reviewed
Oct 24, 2016
| } else { | ||
| session.replaceDialog('signinPrompt', { invalid: true }); | ||
| } | ||
| session.userData.loginData = JSON.parse(results.response); |
Collaborator
There was a problem hiding this comment.
The response here is not a json object.
Author
|
Closing this because it doesn't work. :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed the users array. It was declared at the class level, meaning that it would be tied to one server. In addition, it's not needed as we're only using Passport to simplify the authentication process.