Skip to content

Conversation

@maxkozlovsky
Copy link
Contributor

Add monad_eth_call_executor_get_state() to get counts of currently executing/queued requests and error counts.

Add counter for currently executing requests.

Add counter for number of times the queue was full. Previously this was tracked in rpc code, but was not correctly accounting for the second pool and for possibility of request retried in high pool.

Copilot AI review requested due to automatic review settings October 8, 2025 21:45
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds an API to monitor the state and error counts of the eth call executor, enabling better observability of the request processing system.

  • Adds new state structures to expose pool statistics including executing/queued request counts and queue full conditions
  • Implements tracking of currently executing requests and queue full errors within the pool logic
  • Provides a new public API monad_eth_call_executor_get_state() to retrieve these statistics

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
category/rpc/eth_call.h Defines new state structures and declares the get_state API function
category/rpc/eth_call.cpp Implements state tracking counters and the get_state functionality
category/core/fiber/priority_pool.hpp Adds num_fibers() method to expose fiber count

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@maxkozlovsky maxkozlovsky force-pushed the max/qstate branch 2 times, most recently from c955d3e to 8c0fa35 Compare October 8, 2025 21:57
Add monad_eth_call_executor_get_state() to get counts of currently
executing/queued requests and error counts.

Add counter for currently executing requests.

Add counter for number of times the queue was full. Previously this was
tracked in rpc code, but was not correctly accounting for the second
pool and for possibility of request retried in high pool.
@jhunsaker jhunsaker merged commit 7f95004 into main Oct 13, 2025
8 checks passed
@jhunsaker jhunsaker deleted the max/qstate branch October 13, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants