fix write offset in try_trim_contents() #1908
Merged
+25
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the try_trim_contents() function where the write offset was incorrectly calculated for block devices. The issue occurred when writing back a partial page after TRIM operations.
- Corrects the write offset calculation in
try_trim_contents()by subtractingDISK_PAGE_SIZEfromrange[0]
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Chen-Yifan
force-pushed
the
vicky/fix-trim-offset
branch
2 times, most recently
from
e66e623 to
a2d59e5
Compare
maxkozlovsky
previously approved these changes
Nov 13, 2025
…to start TRIM is not a multiple of disk page size, also includes minor code cleanup.
Chen-Yifan
force-pushed
the
vicky/fix-trim-offset
branch
from
a2d59e5 to
d4bb06b
Compare
maxkozlovsky
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.