Make ro_sq_thread_cpu argument optional #1911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR makes the ro_sq_thread_cpu command-line argument optional in the monad application. Previously, it had a default value of get_nprocs() - 2, which always enabled the SQPOLL kernel thread. Now it defaults to std::nullopt, allowing users to omit the argument to skip SQPOLL thread creation for read-only database operations.
Key changes:
- Changed
ro_sq_thread_cpufromunsignedtostd::optional<unsigned>withstd::nulloptdefault - Updated help text to clarify the optional nature and behavior when omitted
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Chen-Yifan
previously approved these changes
Nov 14, 2025
ro_sq_thread_cpu had default value so it was always not option{}. Make
it option<unsigned> so omitting argument will skip creation of sq poll
thread.
maxkozlovsky
force-pushed
the
max/norosqpoll
branch
from
d2b85db to
959d80d
Compare
jhunsaker
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ro_sq_thread_cpu had default value so it was always not option{}. Make it option so omitting argument will skip creation of sq poll thread.