[execution/monad] Failsafe sanity checks for reward system txs #1921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds failsafe validation for reward system transactions in the Monad blockchain execution layer. The changes ensure that blocks contain at most one reward transaction and that its value does not exceed 25 MON.
- Renamed
static_validate_monad_senderstostatic_validate_monad_bodyto reflect expanded validation scope - Added validation logic to detect multiple reward transactions and enforce maximum reward value of 25 MON
- Introduced comprehensive unit tests to verify the new validation behavior
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| cmd/monad/runloop_monad_ethblocks.cpp | Updated function call to use renamed static_validate_monad_body with transactions parameter |
| cmd/monad/runloop_monad.cpp | Updated function call to use renamed static_validate_monad_body with transactions parameter |
| category/execution/monad/validate_monad_block.hpp | Added forward declaration for Transaction struct, new error enums for reward validation, and updated function signature |
| category/execution/monad/validate_monad_block.cpp | Implemented reward transaction validation logic and error message mappings |
| category/execution/monad/test_validate_monad_block.cpp | Added comprehensive test suite covering valid and invalid reward transaction scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jhunsaker
force-pushed
the
kkuehler/reward_check
branch
from
f88a998 to
46aedbc
Compare
kkuehlz
force-pushed
the
kkuehler/reward_check
branch
from
46aedbc to
b061e5b
Compare
assert there's max 1 reward system tx per block assert that the value of it if it exists is <= 25 MON Adds unit test suite to verify expected behavior.
kkuehlz
force-pushed
the
kkuehler/reward_check
branch
from
b061e5b to
65cc8c2
Compare
jhunsaker
approved these changes
Nov 18, 2025
zander-xyz
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds unit test suite to verify expected behavior.